Add pnacl shims to the chrome build.

Add pnacl shims to the chrome build.

Altering IDL generator to emit pnacl shims.
Building pnacl shims as part of the chrome build.
Publishing pnacl shims in the sdk.

BUG=http://code.google.com/p/nativeclient/issues/detail?id=2957
TEST=None
R=noelallen@chromium.org,jvoung@chromium.org,ncbray@chromium.org,nfullagar@chromium.org,brettw@chromium.org


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=155160

[jvoung (off chromium), 2012-09-05 16:37:19]

http://codereview.chromium.org/10908085/diff/1/ppapi/native_client/src/untrus...
File ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_irt_shim.gyp
(right):

http://codereview.chromium.org/10908085/diff/1/ppapi/native_client/src/untrus...
ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_irt_shim.gyp:18:
'enable_x86_32': 0,
Should you set 'enable_arm': 0, for now too?

[bradn, 2012-09-05 16:43:39]

http://codereview.chromium.org/10908085/diff/1/ppapi/native_client/src/untrus...
File ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_irt_shim.gyp
(right):

http://codereview.chromium.org/10908085/diff/1/ppapi/native_client/src/untrus...
ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_irt_shim.gyp:18:
'enable_x86_32': 0,
On 2012/09/05 16:37:19, jvoung (chromium) wrote:
> Should you set 'enable_arm': 0, for now too?

Done.

[jvoung (off chromium), 2012-09-05 17:07:47]

LGTM

[brettw, 2012-09-05 17:29:21]

lgtm

[nfullagar, 2012-09-05 17:29:47]

one indent nit otherwise lgtm

http://codereview.chromium.org/10908085/diff/9002/ppapi/native_client/src/unt...
File ppapi/native_client/src/untrusted/pnacl_irt_shim/shim_ppapi.c (right):

http://codereview.chromium.org/10908085/diff/9002/ppapi/native_client/src/unt...
ppapi/native_client/src/untrusted/pnacl_irt_shim/shim_ppapi.c:86: sizeof
real_irt_ppapi_hook) {
indent looks strange in the if (cond) above.

[bradn, 2012-09-05 18:25:27]

http://codereview.chromium.org/10908085/diff/9002/ppapi/native_client/src/unt...
File ppapi/native_client/src/untrusted/pnacl_irt_shim/shim_ppapi.c (right):

http://codereview.chromium.org/10908085/diff/9002/ppapi/native_client/src/unt...
ppapi/native_client/src/untrusted/pnacl_irt_shim/shim_ppapi.c:86: sizeof
real_irt_ppapi_hook) {
On 2012/09/05 17:29:47, nfullagar wrote:
> indent looks strange in the if (cond) above.

Agreed but this is a file move between repos and I'd rather keep it the same on
both sides.

[bradn, 2012-09-06 07:17:16]

Dropping sdk change as sdk is in flux.

[commit-bot: I haz the power, 2012-09-06 07:17:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bradnelson@google.com/10908085/21

[commit-bot: I haz the power, 2012-09-06 07:17:33]

Presubmit check for 10908085-21 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit Warnings **
Found lines longer than 80 characters (first 5 shown).
  ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_shim.c, line 145, 81
chars \
  ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_shim.c, line 169, 82
chars \
  ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_shim.c, line 197, 84
chars \
  ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_shim.c, line 218, 82
chars \
  ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_shim.c, line 220, 83
chars

License must match:
.*? Copyright (\(c\) )?(2012|2011|2010|2009|2008|2007|2006|2006-2008) The
Chromium Authors\. All rights reserved\.\n.*? Use of this source code is
governed by a BSD-style license that can be\n.*? found in the LICENSE file\.(?:
\*/)?\n
Found a bad license header in these files:
  ppapi/native_client/src/untrusted/pnacl_irt_shim/shim_entry.c \
  ppapi/native_client/src/untrusted/pnacl_irt_shim/shim_ppapi.c

Presubmit checks took 1.3s to calculate.

[commit-bot: I haz the power, 2012-09-06 07:26:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bradnelson@google.com/10908085/2005

[commit-bot: I haz the power, 2012-09-06 09:49:35]

Change committed as 155160