chrome/browser/api/webdata/web_data_service_base.h - Issue 10908065: Introduce a couple of abstract bases for WebDataService.

Side by Side Diff: chrome/browser/api/webdata/web_data_service_base.h

Issue 10908065: Introduce a couple of abstract bases for WebDataService. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: . Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« chrome/browser/api/webdata/autofill_web_data.h ('K') | « chrome/browser/api/webdata/web_data_results.h ('k') | chrome/browser/api/webdata/web_data_service_consumer.h » ('j') | chrome/browser/autofill/autocomplete_history_manager.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_API_WEBDATA_WEB_DATA_SERVICE_BASE_H_

	6 #define CHROME_BROWSER_API_WEBDATA_WEB_DATA_SERVICE_BASE_H_

	7

	8 #include "chrome/browser/profiles/refcounted_profile_keyed_service.h"

	9

	10 class Profile;

	11

	12 // Base for WebDataService class hierarchy.

	13 class WebDataServiceBase {

	14 public:

	15 // All requests return an opaque handle of the following type.

	16 typedef int Handle;

	17

	18 virtual ~WebDataServiceBase() {}

	19

	20 // Cancel any pending request. You need to call this method if your

	21 // WebDataServiceConsumer is about to be deleted.

	22 virtual void CancelRequest(Handle h) = 0;

	23

	24 // Returns the pointer used as a notification source for this

	25 // service. This may be different than this object's \|this\| pointer.

	26 virtual WebDataServiceBase* GetNotificationSource() = 0;
	erikwright (departed) 2012/09/13 01:45:11 It seems you could return a NotificationSource (co It seems you could return a NotificationSource (const-ref to member instance or by value) and then hide the type of the source. Jói 2012/09/13 12:34:50 I think it's nicer to have it typed... if it's a N Show quoted text On 2012/09/13 01:45:11, erikwright wrote: > It seems you could return a NotificationSource (const-ref to member instance or > by value) and then hide the type of the source. I think it's nicer to have it typed... if it's a NotificationSource and you need to use the pointer, you end up having to first downcast it to Source<WebDataServiceBase> just to get the pointer. erikwright (departed) 2012/09/13 13:28:10 I don't think there's a case in this CL where the Show quoted text On 2012/09/13 12:34:50, Jói wrote: > On 2012/09/13 01:45:11, erikwright wrote: > > It seems you could return a NotificationSource (const-ref to member instance > or > > by value) and then hide the type of the source. > > I think it's nicer to have it typed... if it's a NotificationSource and you need > to use the pointer, you end up having to first downcast it to > Source<WebDataServiceBase> just to get the pointer. I don't think there's a case in this CL where the pointer is needed. It's only used for an equality check, and the untyped NotificationSource _does_ have an equality operator. But I'm happy to leave it this way for now. It just seems to me that encapsulation would be more complete if the specific type that is the source of a notification were not leaked. Jói 2012/09/13 14:48:52 I took another look and yeah, switching to Notific Show quoted text On 2012/09/13 13:28:10, erikwright wrote: > On 2012/09/13 12:34:50, Jói wrote: > > On 2012/09/13 01:45:11, erikwright wrote: > > > It seems you could return a NotificationSource (const-ref to member instance > > or > > > by value) and then hide the type of the source. > > > > I think it's nicer to have it typed... if it's a NotificationSource and you > need > > to use the pointer, you end up having to first downcast it to > > Source<WebDataServiceBase> just to get the pointer. > > I don't think there's a case in this CL where the pointer is needed. It's only > used for an equality check, and the untyped NotificationSource _does_ have an > equality operator. > > But I'm happy to leave it this way for now. It just seems to me that > encapsulation would be more complete if the specific type that is the source of > a notification were not leaked. I took another look and yeah, switching to NotificationSource actually does turn out nice and clean. Did that.
	27 };

	28

	29 #endif // CHROME_BROWSER_API_WEBDATA_WEB_DATA_SERVICE_BASE_H_

OLD	NEW