Support checked mode for field setters.

lib/compiler/implementation/ssa/codegen.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 class SsaCodeGeneratorTask extends CompilerTask {
 
   final JavaScriptBackend backend;
 
   SsaCodeGeneratorTask(JavaScriptBackend backend)
       : this.backend = backend,
@@ skipping 2318 matching lines @@
           const SourceString("listSuperNativeTypeCast"),
       "listSuperTypeCheck":
           const SourceString("listSuperTypeCast"),
       "callTypeCheck":
           const SourceString("callTypeCast"),
       "propertyTypeCheck":
           const SourceString("propertyTypeCast")
     };
 
     if (node.isChecked) {
-      Element element = node.type.computeType(compiler).element;
-      world.registerIsCheck(element);
-      SourceString helper;
-      String additionalArgument;
-      bool nativeCheck =
-          backend.emitter.nativeEmitter.requiresNativeIsCheck(element);
+      Type type = node.type.computeType(compiler);

[floitsch, 2012/08/30 14:35:14]

Add Element element = type.element;
It's used frequently below.

[ngeoffray, 2012/08/30 17:10:21]

Done.

+      world.registerIsCheck(type.element);
 
       if (node.isArgumentTypeCheck) {
-        if (element == compiler.intClass) {
+        if (type.element == compiler.intClass) {
           checkInt(node.checkedInput, '!==');
         } else {
-          assert(element == compiler.numClass);
+          assert(type.element == compiler.numClass);
           checkNum(node.checkedInput, '!==');
         }
         js.Expression test = pop();
         js.Block oldContainer = currentContainer;
         js.Statement body = new js.Block.empty();
         currentContainer = body;
         generateThrowWithHelper('iae', node.checkedInput);
         currentContainer = oldContainer;
         body = unwrapStatement(body);
         pushStatement(new js.If.then(test, body), node);
         return;
       }
 
       assert(node.isCheckedModeCheck || node.isCastTypeCheck);
-      if (element == compiler.stringClass) {
-        helper = const SourceString('stringTypeCheck');
-      } else if (element == compiler.doubleClass) {
-        helper = const SourceString('doubleTypeCheck');
-      } else if (element == compiler.numClass) {
-        helper = const SourceString('numTypeCheck');
-      } else if (element == compiler.boolClass) {
-        helper = const SourceString('boolTypeCheck');
-      } else if (element == compiler.functionClass || element.isTypedef()) {
-        helper = const SourceString('functionTypeCheck');
-      } else if (element == compiler.intClass) {
-        helper = const SourceString('intTypeCheck');
-      } else if (Elements.isStringSupertype(element, compiler)) {
-        additionalArgument = compiler.namer.operatorIs(element);
-        if (nativeCheck) {
-          helper = const SourceString('stringSuperNativeTypeCheck');
-        } else {
-          helper = const SourceString('stringSuperTypeCheck');
-        }
-      } else if (element === compiler.listClass) {
-        helper = const SourceString('listTypeCheck');
-      } else {
-        additionalArgument = compiler.namer.operatorIs(element);
-        if (Elements.isListSupertype(element, compiler)) {
-          if (nativeCheck) {
-            helper = const SourceString('listSuperNativeTypeCheck');
-          } else {
-            helper = const SourceString('listSuperTypeCheck');
-          }
-        } else if (nativeCheck) {
-          helper = const SourceString('callTypeCheck');
-        } else {
-          helper = const SourceString('propertyTypeCheck');
-        }
-      }
+      SourceString helper = backend.getCheckedModeHelper(type);
+      String additionalArgument = compiler.namer.operatorIs(type.element);
       if (node.isCastTypeCheck) {
         helper = castNames[helper.stringValue];
       }
       Element helperElement = compiler.findHelper(helper);
       world.registerStaticUse(helperElement);
       List<js.Expression> arguments = <js.Expression>[];
       use(node.checkedInput);
       arguments.add(pop());
-      if (additionalArgument !== null) {
-        arguments.add(new js.LiteralString("'$additionalArgument'"));
-      }
+      arguments.add(new js.LiteralString("'$additionalArgument'"));
       String helperName = compiler.namer.isolateAccess(helperElement);
       push(new js.Call(new js.VariableUse(helperName), arguments));
     } else {
       use(node.checkedInput);
     }
   }
 }
 
 class SsaOptimizedCodeGenerator extends SsaCodeGenerator {
   SsaOptimizedCodeGenerator(backend, work, parameters, parameterNames)
@@ skipping 504 matching lines @@
   if (leftType.canBeNull() && rightType.canBeNull()) {
     if (left.isConstantNull() || right.isConstantNull() ||
         (leftType.isPrimitive() && leftType == rightType)) {
       return '==';
     }
     return null;
   } else {
     return '===';
   }
 }