Add "inspect background page" to platform app right-click menu.

chrome/browser/tab_contents/render_view_context_menu.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <algorithm>
 #include <set>
 #include <utility>
 
 #include "chrome/browser/tab_contents/render_view_context_menu.h"
 
 #include "base/command_line.h"
 #include "base/logging.h"
 #include "base/metrics/histogram.h"
 #include "base/stl_util.h"
 #include "base/string_util.h"
 #include "base/time.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/app/chrome_command_ids.h"
 #include "chrome/browser/api/prefs/pref_member.h"
 #include "chrome/browser/autocomplete/autocomplete_classifier.h"
 #include "chrome/browser/autocomplete/autocomplete_classifier_factory.h"
 #include "chrome/browser/autocomplete/autocomplete_match.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/debugger/devtools_window.h"
 #include "chrome/browser/download/download_service.h"
 #include "chrome/browser/download/download_service_factory.h"
 #include "chrome/browser/download/download_util.h"
+#include "chrome/browser/extensions/extension_host.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/extensions/extension_system.h"
 #include "chrome/browser/google/google_util.h"
 #include "chrome/browser/prefs/incognito_mode_prefs.h"
 #include "chrome/browser/prefs/pref_service.h"
 #include "chrome/browser/printing/print_preview_context_menu_observer.h"
 #include "chrome/browser/printing/print_preview_tab_controller.h"
 #include "chrome/browser/printing/print_view_manager.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/profiles/profile_io_data.h"
@@ skipping 629 matching lines @@
   else if (has_selection)
     AppendCopyItem();
 
   int index = 0;
   AppendExtensionItems(platform_app->id(), &index);
 
   // Add dev tools for unpacked extensions.
   if (platform_app->location() == Extension::LOAD) {
     menu_model_.AddItemWithStringId(IDC_RELOAD, IDS_CONTENT_CONTEXT_RELOAD);
     AppendDeveloperItems();
+    menu_model_.AddItemWithStringId(IDC_CONTENT_CONTEXT_INSPECTBACKGROUNDPAGE,
+                                    IDS_CONTENT_CONTEXT_INSPECTBACKGROUNDPAGE);
   }
 }
 
 void RenderViewContextMenu::AppendPopupExtensionItems() {
   bool has_selection = !params_.selection_text.empty();
 
   if (params_.is_editable)
     AppendEditableItems();
   else if (has_selection)
     AppendCopyItem();
@@ skipping 469 matching lines @@
       CoreTabHelperDelegate* core_delegate =
           tab_contents->core_tab_helper()->delegate();
       return !core_delegate || core_delegate->CanReloadContents(tab_contents);
     }
 
     case IDC_VIEW_SOURCE:
     case IDC_CONTENT_CONTEXT_VIEWFRAMESOURCE:
       return source_web_contents_->GetController().CanViewSource();
 
     case IDC_CONTENT_CONTEXT_INSPECTELEMENT:
+    case IDC_CONTENT_CONTEXT_INSPECTBACKGROUNDPAGE:
       return IsDevCommandEnabled(id);
 
     case IDC_CONTENT_CONTEXT_VIEWPAGEINFO:
       if (source_web_contents_->GetController().GetActiveEntry() == NULL)
         return false;
       // Disabled if no browser is associated (e.g. desktop notifications).
       if (browser::FindBrowserWithWebContents(source_web_contents_) == NULL)
         return false;
       return true;
 
@@ skipping 549 matching lines @@
       break;
 
     case IDC_VIEW_SOURCE:
       source_web_contents_->ViewSource();
       break;
 
     case IDC_CONTENT_CONTEXT_INSPECTELEMENT:
       Inspect(params_.x, params_.y);
       break;
 
+    case IDC_CONTENT_CONTEXT_INSPECTBACKGROUNDPAGE: {
+      const Extension* platform_app = GetExtension();
+      DCHECK(platform_app);
+      DCHECK(platform_app->is_platform_app());
+
+      extensions::ExtensionHost* host = profile_->GetExtensionProcessManager()->
+          GetBackgroundHostForExtension(platform_app->id());
+      DCHECK(host);

[Marijn Kruisselbrink, 2012/09/14 21:15:18]

Antony: is this safe, or are there possible situations where a platform app
won't have a running background page?

[asargent_no_longer_on_chrome, 2012/09/14 21:57:41]

Let's refactor out the C++ code that the chrome://extensions page dispatches to
since it already handles starting up the background page if needed. That's at:

ExtensionSettingsHandler::HandleInspectMessage in 

chrome/src/chrome/browser/ui/webui/extensions/extension_settings_handler.cc

A good location might be something like:

ExtensionService::inspectBackgroundPage(const std::string& id)

+
+      DevToolsWindow::OpenDevToolsWindow(host->render_view_host());
+      break;
+    }
+
     case IDC_CONTENT_CONTEXT_VIEWPAGEINFO: {
       NavigationController* controller = &source_web_contents_->GetController();
       NavigationEntry* nav_entry = controller->GetActiveEntry();
       Browser* browser =
           browser::FindBrowserWithWebContents(source_web_contents_);
       chrome::ShowPageInfo(browser, source_web_contents_, nav_entry->GetURL(),
                            nav_entry->GetSSL(), true);
       break;
     }
 
@@ skipping 204 matching lines @@
     rvh->NotifyContextMenuClosed(params_.custom_context);
   }
 
   content::NotificationService::current()->Notify(
       chrome::NOTIFICATION_RENDER_VIEW_CONTEXT_MENU_CLOSED,
       content::Source<RenderViewContextMenu>(this),
       content::NotificationService::NoDetails());
 }
 
 bool RenderViewContextMenu::IsDevCommandEnabled(int id) const {
-  if (id == IDC_CONTENT_CONTEXT_INSPECTELEMENT) {
+  if (id == IDC_CONTENT_CONTEXT_INSPECTELEMENT ||
+      id == IDC_CONTENT_CONTEXT_INSPECTBACKGROUNDPAGE) {
     const CommandLine* command_line = CommandLine::ForCurrentProcess();
     if (!profile_->GetPrefs()->GetBoolean(prefs::kWebKitJavascriptEnabled) ||
         command_line->HasSwitch(switches::kDisableJavaScript))
       return false;
 
     // Don't enable the web inspector if the developer tools are disabled via
     // the preference dev-tools-disabled.
     if (profile_->GetPrefs()->GetBoolean(prefs::kDevToolsDisabled))
       return false;
   }
@@ skipping 54 matching lines @@
   source_web_contents_->GetRenderViewHost()->
       ExecuteMediaPlayerActionAtLocation(location, action);
 }
 
 void RenderViewContextMenu::PluginActionAt(
     const gfx::Point& location,
     const WebPluginAction& action) {
   source_web_contents_->GetRenderViewHost()->
       ExecutePluginActionAtLocation(location, action);
 }