Issue 10907166: Upstream chromium side of modal dialogs for webview.

Issue 10907166: Upstream chromium side of modal dialogs for webview. (Closed)

Created:
8 years, 3 months ago by Yaron

Modified:
8 years, 3 months ago

Reviewers:
joth, mkosiba (inactive), Jói

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, erikwright+watch_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Upstream chromium side of modal dialogs for webview. There's still some default handling needed if the embedder doesn't override the handler. Includes clean-up of previous hooks in content that aren't needed anymore. BUG=138483 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=157815

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : rebase #

Patch Set 4 : #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+597 lines, -108 lines)			Patch
M	android_webview/java/src/org/chromium/android_webview/AwContents.java	View	1 2	1 chunk	+21 lines, -0 lines	0 comments	Download
M	android_webview/java/src/org/chromium/android_webview/AwContentsClient.java	View	1 2	2 chunks	+10 lines, -1 line	0 comments	Download
A	android_webview/java/src/org/chromium/android_webview/JsPromptResultReceiver.java	View		1 chunk	+17 lines, -0 lines	0 comments	Download
A	android_webview/java/src/org/chromium/android_webview/JsResultHandler.java	View		1 chunk	+39 lines, -0 lines	0 comments	Download
A	android_webview/java/src/org/chromium/android_webview/JsResultReceiver.java	View		1 chunk	+18 lines, -0 lines	0 comments	Download
M	android_webview/javatests/src/org/chromium/android_webview/test/AndroidWebViewTestBase.java	View	1 2	1 chunk	+9 lines, -0 lines	0 comments	Download
M	android_webview/javatests/src/org/chromium/android_webview/test/NullContentsClient.java	View	1 2	2 chunks	+21 lines, -1 line	0 comments	Download
A	android_webview/javatests/src/org/chromium/android_webview/test/WebViewModalDialogOverrideTest.java	View	1 2	1 chunk	+185 lines, -0 lines	0 comments	Download
M	android_webview/native/android_webview_jni_registrar.cc	View	1 2	2 chunks	+2 lines, -0 lines	0 comments	Download
M	android_webview/native/aw_browser_dependency_factory.h	View		2 chunks	+0 lines, -5 lines	0 comments	Download
M	android_webview/native/aw_contents.h	View	1 2	2 chunks	+13 lines, -0 lines	0 comments	Download
M	android_webview/native/aw_contents.cc	View	1 2 3	3 chunks	+57 lines, -3 lines	0 comments	Download
A	android_webview/native/aw_javascript_dialog_creator.h	View		1 chunk	+41 lines, -0 lines	0 comments	Download
A	android_webview/native/aw_javascript_dialog_creator.cc	View		1 chunk	+63 lines, -0 lines	0 comments	Download
M	android_webview/native/aw_web_contents_delegate.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	android_webview/native/aw_web_contents_delegate.cc	View		2 chunks	+11 lines, -0 lines	0 comments	Download
A	android_webview/native/js_result_handler.h	View		1 chunk	+23 lines, -0 lines	0 comments	Download
A	android_webview/native/js_result_handler.cc	View		1 chunk	+48 lines, -0 lines	0 comments	Download
M	android_webview/native/webview_native.gyp	View	1 2	2 chunks	+5 lines, -0 lines	0 comments	Download
M	base/android/jni_generator/jni_generator.py	View	1 2	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/android/chrome_web_contents_delegate_android.h	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/android/chrome_web_contents_delegate_android.cc	View	1	2 chunks	+6 lines, -0 lines	0 comments	Download
M	chrome/browser/component/web_contents_delegate_android/web_contents_delegate_android.h	View	1 2	2 chunks	+0 lines, -10 lines	0 comments	Download
M	chrome/browser/component/web_contents_delegate_android/web_contents_delegate_android.cc	View	1 2	2 chunks	+1 line, -7 lines	0 comments	Download
M	content/browser/android/content_view_client.h	View	1 2	2 chunks	+0 lines, -10 lines	0 comments	Download
M	content/browser/android/content_view_client.cc	View	1 2	1 chunk	+0 lines, -47 lines	0 comments	Download
M	content/public/android/java/src/org/chromium/content/browser/ContentViewClient.java	View		1 chunk	+0 lines, -24 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Yaron

Almost straight from downstream. Only fixes some presubmits for line-lenght. Also TestCallbackHelperContainer isn't upstream yet ...

8 years, 3 months ago (2012-09-11 01:59:38 UTC) #1

Jói

chrome/browser/component LGTM. BTW, feel free to add a chrome/browser/component/web_contents_delegate_android/OWNERS file. Cheers, Jói

8 years, 3 months ago (2012-09-16 19:25:23 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yfriedman@chromium.org/10907166/12001

8 years, 3 months ago (2012-09-20 17:13:14 UTC) #5

Change committed as 157815

Expand Messages | Collapse Messages