Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Side by Side Diff: net/test/local_test_server_posix.cc

Issue 10907162: Reland: Take 2: Force python test server output to be unbuffered, so it doesn't mix with gtest outpu (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/test/local_test_server.h" 5 #include "net/test/local_test_server.h"
6 6
7 #include <poll.h> 7 #include <poll.h>
8 8
9 #include <vector> 9 #include <vector>
10 10
(...skipping 83 matching lines...) Expand 10 before | Expand all | Expand 10 after
94 94
95 namespace net { 95 namespace net {
96 96
97 bool LocalTestServer::LaunchPython(const FilePath& testserver_path) { 97 bool LocalTestServer::LaunchPython(const FilePath& testserver_path) {
98 // Log is useful in the event you want to run a nearby script (e.g. a test) in 98 // Log is useful in the event you want to run a nearby script (e.g. a test) in
99 // the same environment as the TestServer. 99 // the same environment as the TestServer.
100 VLOG(1) << "LaunchPython called with PYTHONPATH = " << 100 VLOG(1) << "LaunchPython called with PYTHONPATH = " <<
101 getenv(kPythonPathEnv); 101 getenv(kPythonPathEnv);
102 CommandLine python_command(FilePath(FILE_PATH_LITERAL("python"))); 102 CommandLine python_command(FilePath(FILE_PATH_LITERAL("python")));
103 103
104 // Use unbuffered output, so that testserver output doesn't mix with gtest
105 // output in test log files. See http://crbug.com/147368.
106 python_command.AppendArg("-u");
107
104 python_command.AppendArgPath(testserver_path); 108 python_command.AppendArgPath(testserver_path);
105 if (!AddCommandLineArguments(&python_command)) 109 if (!AddCommandLineArguments(&python_command))
106 return false; 110 return false;
107 111
108 int pipefd[2]; 112 int pipefd[2];
109 if (pipe(pipefd) != 0) { 113 if (pipe(pipefd) != 0) {
110 PLOG(ERROR) << "Could not create pipe."; 114 PLOG(ERROR) << "Could not create pipe.";
111 return false; 115 return false;
112 } 116 }
113 117
(...skipping 47 matching lines...) Expand 10 before | Expand all | Expand 10 after
161 165
162 if (!ParseServerData(server_data)) { 166 if (!ParseServerData(server_data)) {
163 LOG(ERROR) << "Could not parse server_data: " << server_data; 167 LOG(ERROR) << "Could not parse server_data: " << server_data;
164 return false; 168 return false;
165 } 169 }
166 170
167 return true; 171 return true;
168 } 172 }
169 173
170 } // namespace net 174 } // namespace net
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698