Allow server sockets to rebind to same port if there is nothing actively listening on that port.

net/socket/tcp_server_socket_libevent.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/socket/tcp_server_socket_libevent.h"
 
 #include <errno.h>
 #include <fcntl.h>
 #include <netdb.h>
 #include <sys/socket.h>
@@ skipping 17 matching lines @@
 
 const int kInvalidSocket = -1;
 
 }  // namespace
 
 TCPServerSocketLibevent::TCPServerSocketLibevent(
     net::NetLog* net_log,
     const net::NetLog::Source& source)
     : socket_(kInvalidSocket),
       accept_socket_(NULL),
+      reuse_address_(false),
       net_log_(BoundNetLog::Make(net_log, NetLog::SOURCE_SOCKET)) {
   net_log_.BeginEvent(NetLog::TYPE_SOCKET_ALIVE,
                       source.ToEventParametersCallback());
 }
 
 TCPServerSocketLibevent::~TCPServerSocketLibevent() {
   if (socket_ != kInvalidSocket)
     Close();
   net_log_.EndEvent(NetLog::TYPE_SOCKET_ALIVE);
 }
 
 int TCPServerSocketLibevent::Listen(const IPEndPoint& address, int backlog) {
   DCHECK(CalledOnValidThread());
   DCHECK_GT(backlog, 0);
   DCHECK_EQ(socket_, kInvalidSocket);
 
   socket_ = socket(address.GetFamily(), SOCK_STREAM, IPPROTO_TCP);
   if (socket_ < 0) {
     PLOG(ERROR) << "socket() returned an error";
     return MapSystemError(errno);
   }
 
   if (SetNonBlocking(socket_)) {
     int result = MapSystemError(errno);
     Close();
     return result;
   }
 
+  int result = SetSocketOptions();
+  if (result < 0) {

[wtc, 2012/09/13 18:31:55]

result < 0 => result != OK

Note: although SetSocketOptions() and bind()/listen() all
return int, SetSocketOptions() returns a Chrome network
error code, whereas bind()/listen() return 0/-1 (the Unix
system call status values).

[justinlin, 2012/09/14 03:54:40]

Done. Nice catch.

+    return result;
+  }
+
   SockaddrStorage storage;
   if (!address.ToSockAddr(storage.addr, &storage.addr_len))
     return ERR_INVALID_ARGUMENT;
 
-  int result = bind(socket_, storage.addr, storage.addr_len);
+  result = bind(socket_, storage.addr, storage.addr_len);
   if (result < 0) {
     PLOG(ERROR) << "bind() returned an error";
     result = MapSystemError(errno);
     Close();
     return result;
   }
 
   result = listen(socket_, backlog);
   if (result < 0) {
     PLOG(ERROR) << "listen() returned an error";
@@ skipping 37 matching lines @@
       return MapSystemError(errno);
     }
 
     accept_socket_ = socket;
     accept_callback_ = callback;
   }
 
   return result;
 }
 
+void TCPServerSocketLibevent::AllowAddressReuse() {
+  DCHECK(CalledOnValidThread());
+  DCHECK_EQ(socket_, kInvalidSocket);
+
+  reuse_address_ = true;
+}
+
+int TCPServerSocketLibevent::SetSocketOptions() {
+  int true_value = 1;
+  if (reuse_address_) {
+    int rv = setsockopt(socket_, SOL_SOCKET, SO_REUSEADDR, &true_value,
+                        sizeof(true_value));
+    if (rv < 0)
+      return MapSystemError(errno);

[wtc, 2012/09/13 18:31:55]

Why didn't you copy the following code from tcp_client_socket_libevent.cc?

#if defined(SO_REUSEPORT)
    rv = setsockopt(socket_, SOL_SOCKET, SO_REUSEPORT, &true_value,
                    sizeof(true_value));
    if (rv < 0)
      return MapSystemError(errno);
#endif

[Sergey Ulanov, 2012/09/13 22:08:45]

I actually don't think we really need this. Yuri added it specifically for
broadcast sockets on mac (though I don't know all details of why it's required
there). See my comments on that issue here:
http://codereview.chromium.org/10739002/ . There is also CL in flight to fix it:
http://codereview.chromium.org/10917235/

[wtc, 2012/09/14 02:36:12]

Thank you. Then we should not copy the SO_REUSEPORT code to
TCPServerSocket.

+  }
+  return OK;
+}
+
 int TCPServerSocketLibevent::AcceptInternal(
     scoped_ptr<StreamSocket>* socket) {
   SockaddrStorage storage;
   int new_socket = HANDLE_EINTR(accept(socket_,
                                        storage.addr,
                                        &storage.addr_len));
   if (new_socket < 0) {
     int net_error = MapSystemError(errno);
     if (net_error != ERR_IO_PENDING)
       net_log_.EndEventWithNetErrorCode(NetLog::TYPE_TCP_ACCEPT, net_error);
@@ skipping 46 matching lines @@
     accept_callback_.Reset();
     callback.Run(result);
   }
 }
 
 void TCPServerSocketLibevent::OnFileCanWriteWithoutBlocking(int fd) {
   NOTREACHED();
 }
 
 }  // namespace net