Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Unified Diff: chrome/browser/extensions/api/rtc_private/rtc_private_api.cc

Issue 10907151: Extensions Docs Server: Enum values do not show up if enum is a type (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/rtc_private/rtc_private_api.cc
diff --git a/chrome/browser/extensions/api/rtc_private/rtc_private_api.cc b/chrome/browser/extensions/api/rtc_private/rtc_private_api.cc
index 57c07a58ac79d273471aced07c56b2e8749392c6..ada236f68580d8965b4f35942d4b28fb56de6cf7 100644
--- a/chrome/browser/extensions/api/rtc_private/rtc_private_api.cc
+++ b/chrome/browser/extensions/api/rtc_private/rtc_private_api.cc
@@ -46,27 +46,20 @@ const char kNameIntentField[] = "name";
const char kPhoneIntentField[] = "phone";
const char kEmailIntentField[] = "email";
-// Returns string representation of intent action.
-const char* GetLaunchAction(RtcPrivateEventRouter::LaunchAction action) {
- const char* action_str = kActivateAction;
+// Returns the ActionType of intent action.
+api::rtc_private::ActionType GetLaunchAction(
+ RtcPrivateEventRouter::LaunchAction action) {
switch (action) {
case RtcPrivateEventRouter::LAUNCH_ACTIVATE:
- action_str = kActivateAction;
- break;
+ return api::rtc_private::RTC_PRIVATE_ACTION_TYPE_NONE;
case RtcPrivateEventRouter::LAUNCH_CHAT:
- action_str = kChatAction;
- break;
+ return api::rtc_private::RTC_PRIVATE_ACTION_TYPE_CHAT;
case RtcPrivateEventRouter::LAUNCH_VOICE:
- action_str = kVoiceAction;
- break;
+ return api::rtc_private::RTC_PRIVATE_ACTION_TYPE_VOICE;
case RtcPrivateEventRouter::LAUNCH_VIDEO:
- action_str = kVideoAction;
- break;
- default:
- NOTREACHED() << "Unknown action " << action;
- break;
+ return api::rtc_private::RTC_PRIVATE_ACTION_TYPE_VIDEO;
}
- return action_str;
+ return api::rtc_private::RTC_PRIVATE_ACTION_TYPE_NONE;
}
// Creates JSON payload string for contact web intent data.

Powered by Google App Engine
This is Rietveld 408576698