chrome/browser/extensions/api/system_info_storage/system_info_storage_apitest.cc - Issue 10907151: Extensions Docs Server: Enum values do not show up if enum is a type

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/system_info_storage/system_info_storage_apitest.cc

Issue 10907151: Extensions Docs Server: Enum values do not show up if enum is a type (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: add back braces Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/socket/socket_api.cc ('K') | « chrome/browser/extensions/api/system_info_storage/storage_info_provider_win.cc ('k') | tools/json_schema_compiler/cc_generator.py » ('j') | tools/json_schema_compiler/cc_generator.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/system_info_storage/system_info_storage_apitest.cc

diff --git a/chrome/browser/extensions/api/system_info_storage/system_info_storage_apitest.cc b/chrome/browser/extensions/api/system_info_storage/system_info_storage_apitest.cc

index 3f7e77a81f26c481684716133f481a80fa30720d..588fd971cc19de2017b9eddb6144f330074e77bc 100644

--- a/chrome/browser/extensions/api/system_info_storage/system_info_storage_apitest.cc

+++ b/chrome/browser/extensions/api/system_info_storage/system_info_storage_apitest.cc

@@ -32,7 +32,10 @@ class MockStorageInfoProvider : public StorageInfoProvider {

linked_ptr<StorageUnitInfo> unit(new StorageUnitInfo());

unit->id = "0xbeaf";

- unit->type = systeminfo::kStorageTypeUnknown;

+ if (!api::experimental_system_info_storage::

+ GetEnumFromString(systeminfo::kStorageTypeUnknown, &unit->type)) {

+ return false;

+ }

unit->capacity = 4098;

unit->available_capacity = 1024;