chrome/browser/extensions/api/system_info_storage/storage_info_provider_mac.cc - Issue 10907151: Extensions Docs Server: Enum values do not show up if enum is a type

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/system_info_storage/storage_info_provider_mac.cc

Issue 10907151: Extensions Docs Server: Enum values do not show up if enum is a type (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: add back braces Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/socket/socket_api.cc ('K') | « chrome/browser/extensions/api/socket/socket_apitest.cc ('k') | chrome/browser/extensions/api/system_info_storage/storage_info_provider_win.cc » ('j') | tools/json_schema_compiler/cc_generator.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/system_info_storage/storage_info_provider_mac.cc

diff --git a/chrome/browser/extensions/api/system_info_storage/storage_info_provider_mac.cc b/chrome/browser/extensions/api/system_info_storage/storage_info_provider_mac.cc

index 53537d7b5b2243ff20863662aa45d47d8f0591c0..03fff0b29a9ae134ade16755131afddfdcc4e823 100644

--- a/chrome/browser/extensions/api/system_info_storage/storage_info_provider_mac.cc

+++ b/chrome/browser/extensions/api/system_info_storage/storage_info_provider_mac.cc

@@ -79,7 +79,10 @@ bool StorageInfoProviderMac::QueryUnitInfo(const std::string& id,

type = dev_path_to_type_map_[volume_dev].empty() ?

systeminfo::kStorageTypeUnknown : dev_path_to_type_map_[volume_dev];

}

- info->type = type;

+ if (!api::experimental_system_info_storage::

+ GetEnumFromString(type, &info->type)) {

+ return false;

+ }

// TODO(joshuagl): we're reporting different values than Disk Utility.

// Is there an alternative API to get this information that doesn't use

// statfs? NSFileManager's attributesOfFileSystemForPath uses statfs.