tools/json_schema_compiler/cpp_type_generator.py - Issue 10907151: Extensions Docs Server: Enum values do not show up if enum is a type

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/json_schema_compiler/cpp_type_generator.py

Issue 10907151: Extensions Docs Server: Enum values do not show up if enum is a type (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/json_schema_compiler/cpp_type_generator.py

diff --git a/tools/json_schema_compiler/cpp_type_generator.py b/tools/json_schema_compiler/cpp_type_generator.py

index 95329c3f548614603df6fd0849879f852c57c086..b51edfb639047c48aa5eb6bfb18237e05f377585 100644

--- a/tools/json_schema_compiler/cpp_type_generator.py

+++ b/tools/json_schema_compiler/cpp_type_generator.py

@@ -222,7 +222,8 @@ class CppTypeGenerator(object):

'name': type_name,

'item_type': self.GetType(namespace.types[type_].item_type,

wrap_optional=True)})

- else:

+ # Enums cannot be forward declared.

+ elif namespace.types[type_].type_ != PropertyType.ENUM:

c.Append('struct %s;' % type_name)

c.Append('}')

c.Concat(self.GetNamespaceStart())