Extensions Docs Server: Enum values do not show up if enum is a type

chrome/browser/extensions/api/media_galleries/media_galleries_api.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Implements the Chrome Extensions Media Galleries API.
 
 #include "chrome/browser/extensions/api/media_galleries/media_galleries_api.h"
 
 #include <string>
 #include <vector>
@@ skipping 52 matching lines @@
 MediaGalleriesGetMediaFileSystemsFunction::
     ~MediaGalleriesGetMediaFileSystemsFunction() {}
 
 bool MediaGalleriesGetMediaFileSystemsFunction::RunImpl() {
   if (!ApiIsAccessible(&error_))
     return false;
 
   scoped_ptr<GetMediaFileSystems::Params> params(
       GetMediaFileSystems::Params::Create(*args_));
   EXTENSION_FUNCTION_VALIDATE(params.get());
-  MediaGalleries::GetMediaFileSystemsInteractivity interactive = "no";
-  if (params->details.get() && params->details->interactive.get())
-    interactive = *params->details->interactive;
+  MediaGalleries::GetMediaFileSystemsInteractivity interactive =
+      MediaGalleries::GETMEDIAFILESYSTEMSINTERACTIVITY_NO;

[not at google - send to devlin, 2012/09/14 01:44:51]

wow... what happened here? something funky with the string enum conversion.

this should be GET_MEDIA_FILESYSTEMS_INTERACTIVITY_NO (see media_galleries.idl)

and so on

[cduvall, 2012/09/17 22:07:46]

Done.

+  if (params->details.get() && params->details->interactive !=
+          MediaGalleries::GETMEDIAFILESYSTEMSINTERACTIVITY_NONE) {
+    interactive = params->details->interactive;
+  }

[not at google - send to devlin, 2012/09/14 01:44:51]

also this can use switch now that it's an enum.

[cduvall, 2012/09/17 22:07:46]

Done.

 
-  if (interactive == "yes") {
+  if (interactive == MediaGalleries::GETMEDIAFILESYSTEMSINTERACTIVITY_YES) {
     ShowDialog();
     return true;
-  } else if (interactive == "if_needed") {
+  } else if (interactive ==
+      MediaGalleries::GETMEDIAFILESYSTEMSINTERACTIVITY_IF_NEEDED) {
     std::vector<MediaFileSystemRegistry::MediaFSInfo> filesystems =
         MediaFileSystemRegistry::GetInstance()->GetMediaFileSystemsForExtension(
             render_view_host(), GetExtension());
     if (filesystems.empty())
       ShowDialog();
     else
       ReturnGalleries(filesystems);
 
     return true;
-  } else if (interactive == "no") {
+  } else if (interactive ==
+      MediaGalleries::GETMEDIAFILESYSTEMSINTERACTIVITY_NO) {
     GetAndReturnGalleries();
     return true;
   }
 
   error_ = kInvalidInteractive;
   return false;
 }
 
 void MediaGalleriesGetMediaFileSystemsFunction::GetAndReturnGalleries() {
   std::vector<MediaFileSystemRegistry::MediaFSInfo> filesystems =
@@ skipping 60 matching lines @@
 bool MediaGalleriesAssembleMediaFileFunction::RunImpl() {
   if (!ApiIsAccessible(&error_))
     return false;
 
   // TODO(vandebo) Update the metadata and return the new file.
   SetResult(Value::CreateNullValue());
   return true;
 }
 
 }  // namespace extensions