Extensions Docs Server: Enum values do not show up if enum is a type

chrome/browser/extensions/api/downloads/downloads_api.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/downloads/downloads_api.h"
 
 #include <algorithm>
 #include <cctype>
 #include <iterator>
 #include <set>
@@ skipping 408 matching lines @@
 
   DownloadQuery query_out;
 
   if (query_in.limit.get()) {
     if (*query_in.limit.get() < 0) {
       *error = download_extension_errors::kInvalidQueryLimit;
       return;
     }
     query_out.Limit(*query_in.limit.get());
   }
-  if (query_in.state.get()) {
-    DownloadItem::DownloadState state = StateEnumFromString(
-        *query_in.state.get());
+  std::string state_string;
+  scoped_ptr<base::Value> state_value(
+      extensions::api::downloads::CreateEnumValue(query_in.state));
+  if (state_value.get()) {
+    state_value->GetAsString(&state_string);
+    DownloadItem::DownloadState state = StateEnumFromString(state_string);

[not at google - send to devlin, 2012/09/14 01:44:51]

if you generate a ToString as I suggested, this would be much simpler.

[cduvall, 2012/09/17 22:07:46]

Done.

     if (state == DownloadItem::MAX_DOWNLOAD_STATE) {
       *error = download_extension_errors::kInvalidStateError;
       return;
     }
     query_out.AddFilter(state);
   }
-  if (query_in.danger.get()) {
-    content::DownloadDangerType danger_type =
-        DangerEnumFromString(*query_in.danger.get());
+  std::string danger_string;
+  scoped_ptr<base::Value> danger_value(
+      extensions::api::downloads::CreateEnumValue(query_in.danger));
+  if (danger_value.get()) {
+    danger_value->GetAsString(&danger_string);
+    content::DownloadDangerType danger_type = DangerEnumFromString(
+        danger_string);

[not at google - send to devlin, 2012/09/14 01:44:51]

etc

[cduvall, 2012/09/17 22:07:46]

Done.

     if (danger_type == content::DOWNLOAD_DANGER_TYPE_MAX) {
       *error = download_extension_errors::kInvalidDangerTypeError;
       return;
     }
     query_out.AddFilter(danger_type);
   }
   if (query_in.order_by.get()) {
     CompileDownloadQueryOrderBy(*query_in.order_by.get(), error, &query_out);
     if (!error->empty())
       return;
@@ skipping 114 matching lines @@
          ++iter) {
       const HeaderNameValuePair& name_value = **iter;
       if (!net::HttpUtil::IsSafeHeader(name_value.name)) {
         error_ = download_extension_errors::kGenericError;
         return false;
       }
       download_params->add_request_header(name_value.name, name_value.value);
     }
   }
 
-  if (options.method.get())
-    download_params->set_method(*options.method.get());
+  if (options.method != extensions::api::downloads::HTTPMETHOD_NONE) {
+    std::string method;
+    extensions::api::downloads::CreateEnumValue(options.method)->GetAsString(
+        &method);
+    download_params->set_method(method);
+  }

[not at google - send to devlin, 2012/09/14 01:44:51]

etc

[cduvall, 2012/09/17 22:07:46]

Done.

   if (options.body.get())
-    download_params->set_post_body(*options.body.get());
+    download_params->set_post_body(*options.body);

[benjhayden, 2012/09/14 13:17:48]

Why remove the .get()? I think it's more explicit than using the operator* on
the scoped_ptr directly.

[cduvall, 2012/09/17 22:07:46]

Done.

   download_params->set_callback(base::Bind(
       &DownloadsDownloadFunction::OnStarted, this));
   // Prevent login prompts for 401/407 responses.
   download_params->set_load_flags(net::LOAD_DO_NOT_PROMPT_FOR_LOGIN);
 
   DownloadManager* manager = BrowserContext::GetDownloadManager(
       current_profile);
   manager->DownloadUrl(download_params.Pass());
   RecordApiFunctions(DOWNLOADS_FUNCTION_DOWNLOAD);
   return true;
@@ skipping 397 matching lines @@
   if (profile_->HasOffTheRecordProfile() &&
       !profile_->IsOffTheRecord()) {
     DispatchEventInternal(
         profile_->GetOffTheRecordProfile(),
         event_name,
         json_args,
         scoped_ptr<base::ListValue>(args->DeepCopy()));
   }
   DispatchEventInternal(profile_, event_name, json_args, args.Pass());
 }