Support an --install-from-webstore command line switch

chrome/browser/extensions/webstore_inline_installer.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_WEBSTORE_INLINE_INSTALLER_H_
 #define CHROME_BROWSER_EXTENSIONS_WEBSTORE_INLINE_INSTALLER_H_
 
 #include <string>
 
 #include "base/memory/ref_counted.h"
@@ skipping 15 matching lines @@
 namespace extensions {
 class Extension;
 class SafeWebstoreResponseParser;
 
 // Manages inline installs requested by a page (downloads and parses metadata
 // from the webstore, shows the install UI, starts the download once the user
 // confirms).  Clients must implement the WebstoreInlineInstaller::Delegate
 // interface to be notified when the inline install completes (successfully or
 // not). The client will not be notified if the WebContents that this install
 // request is attached to goes away.
 class WebstoreInlineInstaller

[Mihai Parparita -not on Chrome, 2012/09/07 22:01:36]

Add a TODO about renaming this class, since it's no longer inline
installation-specific. WebstoreStandaloneInstaller perhaps? (since it doesn't
depend on the webstore web UI)

[asargent_no_longer_on_chrome, 2012/09/14 23:24:35]

Done.

     : public base::RefCountedThreadSafe<WebstoreInlineInstaller>,
       public ExtensionInstallPrompt::Delegate,
       public content::WebContentsObserver,
       public net::URLFetcherDelegate,
       public WebstoreInstaller::Delegate,
       public WebstoreInstallHelper::Delegate {
  public:
-  class Delegate {
-   public:
-    virtual void OnInlineInstallSuccess(int install_id,
-                                        int return_route_id) = 0;
-    virtual void OnInlineInstallFailure(int install_id,
-                                        int return_route_id,
-                                        const std::string& error) = 0;
-  };
+  // A callback for when the install process completes successfully or not. If
+  // there was a failure, |success| will be false and |error| may contain a
+  // developer-readable error message about why it failed.
+  typedef base::Callback<void(bool success, const std::string& error)> Callback;

[Mihai Parparita -not on Chrome, 2012/09/07 22:01:36]

This needs a base/callback.h #include.

[asargent_no_longer_on_chrome, 2012/09/14 23:24:35]

Done.

 
   WebstoreInlineInstaller(content::WebContents* web_contents,
-                          int install_id,
-                          int return_route_id,
                           std::string webstore_item_id,
+                          bool require_verified_site,

[Mihai Parparita -not on Chrome, 2012/09/07 22:01:36]

An enum param would be more readable.

[asargent_no_longer_on_chrome, 2012/09/14 23:24:35]

Done.

                           GURL requestor_url,
-                          Delegate* d);
+                          Callback callback);
   void BeginInstall();
 
  private:
   friend class base::RefCountedThreadSafe<WebstoreInlineInstaller>;
   friend class SafeWebstoreResponseParser;
   FRIEND_TEST_ALL_PREFIXES(WebstoreInlineInstallerTest, DomainVerification);
 
   virtual ~WebstoreInlineInstaller();
 
   // Several delegate/client inteface implementations follow. The normal flow
@@ skipping 39 matching lines @@
   virtual void OnExtensionInstallFailure(const std::string& id,
                                          const std::string& error) OVERRIDE;
 
   void CompleteInstall(const std::string& error);
 
   // Checks whether the install is initiated by a page in the verified site
   // (which is at least a domain, but can also have a port or a path).
   static bool IsRequestorURLInVerifiedSite(const GURL& requestor_url,
                                            const std::string& verified_site);
 
-  int install_id_;
-  int return_route_id_;
   std::string id_;
+  bool require_verified_site_;
   GURL requestor_url_;
-  Delegate* delegate_;
+  Callback callback_;
   scoped_ptr<ExtensionInstallPrompt> install_ui_;
 
   // For fetching webstore JSON data.
   scoped_ptr<net::URLFetcher> webstore_data_url_fetcher_;
 
   // Extracted from the webstore JSON data response.
   std::string localized_name_;
   std::string localized_description_;
   std::string localized_user_count_;
   double average_rating_;
   int rating_count_;
   scoped_ptr<DictionaryValue> webstore_data_;
   scoped_ptr<DictionaryValue> manifest_;
   scoped_refptr<Extension> dummy_extension_;
   SkBitmap icon_;
 
   DISALLOW_IMPLICIT_CONSTRUCTORS(WebstoreInlineInstaller);
 };
 
 }  // namespace extensions
 
 #endif  // CHROME_BROWSER_EXTENSIONS_WEBSTORE_INLINE_INSTALLER_H_