Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2610)

Unified Diff: chrome/browser/resources/ntp_search/tile_page.js

Issue 10907065: NTP5: Fix page blacklisting and remove recently closed tabs when they're clicked. Fix the styling … (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase and respond to Evan's comments. Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/ntp_search/thumbnail_page.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/ntp_search/tile_page.js
diff --git a/chrome/browser/resources/ntp_search/tile_page.js b/chrome/browser/resources/ntp_search/tile_page.js
index debad1b7c21427c404bd6c7aae8ea243ad0d1b42..6a26bab3516f8f431b376dffb1d7344899758d53 100644
--- a/chrome/browser/resources/ntp_search/tile_page.js
+++ b/chrome/browser/resources/ntp_search/tile_page.js
@@ -305,25 +305,6 @@ cr.define('ntp', function() {
},
/**
- * The notification content of this tile (if any, otherwise null).
- * @type {!HTMLElement}
- */
- get notification() {
- return this.content_.firstChild.id == 'notification-container' ?
- this.content_.firstChild : null;
- },
- /**
- * The notification content of this tile (if any, otherwise null).
- * @type {!HTMLElement}
- */
- set notification(node) {
- assert(node instanceof HTMLElement, '|node| isn\'t an HTMLElement!');
- // NOTE: Implicitly removes from DOM if |node| is inside it.
- this.content_.insertBefore(node, this.content_.firstChild);
- this.positionNotification_();
- },
-
- /**
* Removes the tilePage from the DOM and cleans up event handlers.
*/
remove: function() {
@@ -421,13 +402,6 @@ cr.define('ntp', function() {
handleCardDeselection_: function(e) {
},
- /**
- * Position the notification if there's one showing.
- * TODO(pedrosimonetti): Fix the position of the notification.
- */
- positionNotification_: function() {
- },
-
// #########################################################################
// Extended Chrome Instant
// #########################################################################
« no previous file with comments | « chrome/browser/resources/ntp_search/thumbnail_page.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698