Consolidate bubble border code.

ui/views/bubble/bubble_delegate.h

Index: ui/views/bubble/bubble_delegate.h
diff --git a/ui/views/bubble/bubble_delegate.h b/ui/views/bubble/bubble_delegate.h
index dd29da79bdfce68f26f1b407353a6a101a587dd8..ed37a7b13f32c2ff72fe4ba84b62fe1c378ed128 100644
--- a/ui/views/bubble/bubble_delegate.h
+++ b/ui/views/bubble/bubble_delegate.h
@@ -67,6 +67,11 @@ class VIEWS_EXPORT BubbleDelegateView : public WidgetDelegateView,
     arrow_location_ = arrow_location;
   }
 
+  BubbleBorder::Shadow border_shadow() const { return border_shadow_; }
+  void set_border_shadow(BubbleBorder::Shadow border_shadow) {

[msw, 2012/09/18 19:33:42]

nit: this fits on one line if you s/|border_shadow|/|shadow|/

[xiyuan, 2012/09/19 18:20:09]

Done.

+    border_shadow_ = border_shadow;
+  }
+
   SkColor color() const { return color_; }
   void set_color(SkColor color) { color_ = color; }
 
@@ -87,9 +92,9 @@ class VIEWS_EXPORT BubbleDelegateView : public WidgetDelegateView,
   bool accept_events() const { return accept_events_; }
   void set_accept_events(bool accept_events) { accept_events_ = accept_events; }
 
-  bool try_mirroring_arrow() const { return try_mirroring_arrow_; }
-  void set_try_mirroring_arrow(bool try_mirroring_arrow) {
-    try_mirroring_arrow_ = try_mirroring_arrow;
+  bool try_fit_bubble() const { return try_fit_bubble_; }

[msw, 2012/09/18 19:33:42]

This name seems worse; consider adjust_if_offscreen or similar.

[xiyuan, 2012/09/19 18:20:09]

Done.

+  void set_try_fit_bubble(bool try_fit_bubble) {
+    try_fit_bubble_ = try_fit_bubble;
   }
 
   // Get the arrow's anchor rect in screen space.
@@ -173,6 +178,9 @@ class VIEWS_EXPORT BubbleDelegateView : public WidgetDelegateView,
   // The arrow's location on the bubble.
   BubbleBorder::ArrowLocation arrow_location_;
 
+  // Bubble border shadow to use.
+  BubbleBorder::Shadow border_shadow_;
+
   // The background color of the bubble.
   SkColor color_;
 
@@ -195,9 +203,9 @@ class VIEWS_EXPORT BubbleDelegateView : public WidgetDelegateView,
   // Specifies whether the popup accepts events or lets them pass through.
   bool accept_events_;
 
-  // If true (defaults to true), the arrow may be mirrored to fit the
-  // bubble on screen better.
-  bool try_mirroring_arrow_;
+  // If true (defaults to true), the arrow may be mirrored and moved o fit the

[msw, 2012/09/18 19:33:42]

nit: s/o/to

[xiyuan, 2012/09/19 18:20:09]

Done.

+  // bubble on screen better. It would be a no-op if bubble has no arrow.

[msw, 2012/09/18 19:33:42]

nit: "*the* bubble"

[xiyuan, 2012/09/19 18:20:09]

Done.

+  bool try_fit_bubble_;
 
   // Parent native window of the bubble.
   gfx::NativeView parent_window_;