Consolidate bubble border code.

ui/views/bubble/bubble_frame_view.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_VIEWS_BUBBLE_BUBBLE_FRAME_VIEW_H_
 #define UI_VIEWS_BUBBLE_BUBBLE_FRAME_VIEW_H_
 
 #include "base/basictypes.h"
 #include "base/compiler_specific.h"
 #include "base/gtest_prod_util.h"
@@ skipping 24 matching lines @@
 
   // View overrides:
   virtual gfx::Size GetPreferredSize() OVERRIDE;
 
   BubbleBorder* bubble_border() const { return bubble_border_; }
 
   gfx::Insets content_margins() const { return content_margins_; }
 
   // Given the size of the contents and the rect to point at, returns the bounds
   // of the bubble window. The bubble's arrow location may change if the bubble
-  // does not fit on the monitor and |try_mirroring_arrow| is true.
+  // does not fit on the monitor and |try_fit_bubble| is true.
   gfx::Rect GetUpdatedWindowBounds(const gfx::Rect& anchor_rect,
                                    gfx::Size client_size,
-                                   bool try_mirroring_arrow);
+                                   bool try_fit_bubble);
 
   void SetBubbleBorder(BubbleBorder* border);
 
  protected:
   // Returns the bounds for the monitor showing the specified |rect|.
   // This function is virtual to support testing environments.
   virtual gfx::Rect GetMonitorBounds(const gfx::Rect& rect);
 
  private:
   FRIEND_TEST_ALL_PREFIXES(BubbleFrameViewTest, GetBoundsForClientView);
 
   // Mirrors the bubble's arrow location on the |vertical| or horizontal axis,
   // if the generated window bounds don't fit in the monitor bounds.
   void MirrorArrowIfOffScreen(bool vertical,
                               const gfx::Rect& anchor_rect,
                               const gfx::Size& client_size);
 
+  // Move arrow (by setting its offset) to make bubble fit in the monitor

[msw, 2012/09/18 19:33:42]

nit: grammar; consider: "Adjust the bubble's arrow offsets if the generated
window bounds don't fit in the monitor bounds."

[xiyuan, 2012/09/19 18:20:09]

Done.

+  // bounds.
+  void OffsetArrowIfOffScreen(const gfx::Rect& anchor_rect,
+                              const gfx::Size& client_size);
+
   // The bubble border.
   BubbleBorder* bubble_border_;
 
   // Margins between the content and the inside of the border, in pixels.
   gfx::Insets content_margins_;
 
   DISALLOW_COPY_AND_ASSIGN(BubbleFrameView);
 };
 
 }  // namespace views
 
 #endif  // UI_VIEWS_BUBBLE_BUBBLE_FRAME_VIEW_H_