Consolidate bubble border code.

ui/views/bubble/bubble_delegate.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_VIEWS_BUBBLE_BUBBLE_DELEGATE_H_
 #define UI_VIEWS_BUBBLE_BUBBLE_DELEGATE_H_
 
 #include "base/gtest_prod_util.h"
 #include "ui/base/animation/animation_delegate.h"
 #include "ui/views/bubble/bubble_border.h"
@@ skipping 49 matching lines @@
   }
 
   View* anchor_view() const { return anchor_view_; }
   Widget* anchor_widget() const { return anchor_widget_; }
 
   BubbleBorder::ArrowLocation arrow_location() const { return arrow_location_; }
   void set_arrow_location(BubbleBorder::ArrowLocation arrow_location) {
     arrow_location_ = arrow_location;
   }
 
+  BubbleBorder::Shadow border_shadow() const { return border_shadow_; }
+  void set_border_shadow(BubbleBorder::Shadow border_shadow) {

[msw, 2012/09/18 19:33:42]

nit: this fits on one line if you s/|border_shadow|/|shadow|/

[xiyuan, 2012/09/19 18:20:09]

Done.

+    border_shadow_ = border_shadow;
+  }
+
   SkColor color() const { return color_; }
   void set_color(SkColor color) { color_ = color; }
 
   const gfx::Insets& margins() const { return margins_; }
   void set_margins(const gfx::Insets& margins) { margins_ = margins; }
 
   void set_anchor_insets(const gfx::Insets& insets) { anchor_insets_ = insets; }
   const gfx::Insets& anchor_insets() const { return anchor_insets_; }
 
   gfx::NativeView parent_window() const { return parent_window_; }
   void set_parent_window(gfx::NativeView window) { parent_window_ = window; }
 
   bool use_focusless() const { return use_focusless_; }
   void set_use_focusless(bool use_focusless) {
     use_focusless_ = use_focusless;
   }
 
   bool accept_events() const { return accept_events_; }
   void set_accept_events(bool accept_events) { accept_events_ = accept_events; }
 
-  bool try_mirroring_arrow() const { return try_mirroring_arrow_; }
-  void set_try_mirroring_arrow(bool try_mirroring_arrow) {
-    try_mirroring_arrow_ = try_mirroring_arrow;
+  bool try_fit_bubble() const { return try_fit_bubble_; }

[msw, 2012/09/18 19:33:42]

This name seems worse; consider adjust_if_offscreen or similar.

[xiyuan, 2012/09/19 18:20:09]

Done.

+  void set_try_fit_bubble(bool try_fit_bubble) {
+    try_fit_bubble_ = try_fit_bubble;
   }
 
   // Get the arrow's anchor rect in screen space.
   virtual gfx::Rect GetAnchorRect();
 
   // Show the bubble's widget (and |border_widget_| on Windows).
   void Show();
 
   // Fade the bubble in or out via Widget transparency.
   // Fade in calls Widget::Show; fade out calls Widget::Close upon completion.
@@ skipping 63 matching lines @@
 
   // The anchor point used in the absence of an anchor view.
   gfx::Point anchor_point_;
 
   // If true, the bubble will re-anchor (and may resize) with |anchor_widget_|.
   bool move_with_anchor_;
 
   // The arrow's location on the bubble.
   BubbleBorder::ArrowLocation arrow_location_;
 
+  // Bubble border shadow to use.
+  BubbleBorder::Shadow border_shadow_;
+
   // The background color of the bubble.
   SkColor color_;
 
   // The margins between the content and the inside of the border.
   gfx::Insets margins_;
 
   // Insets applied to the |anchor_view_| bounds.
   gfx::Insets anchor_insets_;
 
   // Original opacity of the bubble.
   int original_opacity_;
 
   // The widget hosting the border for this bubble (non-Aura Windows only).
   Widget* border_widget_;
 
   // Create a popup window for focusless bubbles on Linux/ChromeOS.
   // These bubbles are not interactive and should not gain focus.
   bool use_focusless_;
 
   // Specifies whether the popup accepts events or lets them pass through.
   bool accept_events_;
 
-  // If true (defaults to true), the arrow may be mirrored to fit the
-  // bubble on screen better.
-  bool try_mirroring_arrow_;
+  // If true (defaults to true), the arrow may be mirrored and moved o fit the

[msw, 2012/09/18 19:33:42]

nit: s/o/to

[xiyuan, 2012/09/19 18:20:09]

Done.

+  // bubble on screen better. It would be a no-op if bubble has no arrow.

[msw, 2012/09/18 19:33:42]

nit: "*the* bubble"

[xiyuan, 2012/09/19 18:20:09]

Done.

+  bool try_fit_bubble_;
 
   // Parent native window of the bubble.
   gfx::NativeView parent_window_;
 
   DISALLOW_COPY_AND_ASSIGN(BubbleDelegateView);
 };
 
 }  // namespace views
 
 #endif  // UI_VIEWS_BUBBLE_BUBBLE_DELEGATE_H_