Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Unified Diff: chrome/browser/ui/views/action_box_menu.cc

Issue 10905296: Adjusted action box menu position relative to omnibox and action box menu button. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/action_box_menu.cc
diff --git a/chrome/browser/ui/views/action_box_menu.cc b/chrome/browser/ui/views/action_box_menu.cc
index 4412d03c87188462196e16303dceef1251d5d93b..8af4aeb9e7b9380fd1380497065d57f3a16d6bcc 100644
--- a/chrome/browser/ui/views/action_box_menu.cc
+++ b/chrome/browser/ui/views/action_box_menu.cc
@@ -40,15 +40,15 @@ void ActionBoxMenu::Init() {
PopulateMenu();
}
-void ActionBoxMenu::RunMenu(views::MenuButton* menu_button) {
- gfx::Point screen_location;
- views::View::ConvertPointToScreen(menu_button, &screen_location);
+void ActionBoxMenu::RunMenu(views::MenuButton* menu_button,
+ gfx::Point menu_offset) {
+ views::View::ConvertPointToScreen(menu_button, &menu_offset);
menu_runner_.reset(new views::MenuRunner(root_));
// Ignore the result since we don't need to handle a deleted menu specially.
ignore_result(
menu_runner_->RunMenuAt(menu_button->GetWidget(),
menu_button,
- gfx::Rect(screen_location, menu_button->size()),
+ gfx::Rect(menu_offset, menu_button->size()),
views::MenuItemView::TOPRIGHT,
views::MenuRunner::HAS_MNEMONICS));
}
« no previous file with comments | « chrome/browser/ui/views/action_box_menu.h ('k') | chrome/browser/ui/views/location_bar/action_box_button_view.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698