Keep a web dialog window centered over the content area

content/browser/web_contents/web_contents_view_aura.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/web_contents/web_contents_view_aura.h"
 
 #include "base/utf_string_conversions.h"
 #include "content/browser/renderer_host/dip_util.h"
 #include "content/browser/renderer_host/render_view_host_factory.h"
 #include "content/browser/web_contents/interstitial_page_impl.h"
@@ skipping 471 matching lines @@
 
 gfx::Size WebContentsViewAura::GetMinimumSize() const {
   return gfx::Size();
 }
 
 void WebContentsViewAura::OnBoundsChanged(const gfx::Rect& old_bounds,
                                           const gfx::Rect& new_bounds) {
   SizeChangedCommon(new_bounds.size());
   if (delegate_.get())
     delegate_->SizeChanged(new_bounds.size());
+
+  // Constrained web dialog windows, need to be kept centered over our content
+  // area. Note that the dialog is the second child - so we start with index 1.
+  for (size_t i = 1; i < window_->children().size(); i++) {

[sky, 2012/09/14 17:23:21]

Now you've got me worried. Add a property that is only set by constrained
windows so you know you're setting the bounds of something you intend to.

[Mr4D (OOO till 08-26), 2012/09/14 20:44:03]

Aha! I knew it! :) Done.

+    gfx::Rect bounds = window_->children()[i]->bounds();
+    bounds.Offset((new_bounds.width() - old_bounds.width()) / 2,
+                  (new_bounds.height() - old_bounds.height()) / 2);
+    window_->children()[i]->SetBounds(bounds);
+  }
 }
 
 void WebContentsViewAura::OnFocus(aura::Window* old_focused_window) {
 }
 
 void WebContentsViewAura::OnBlur() {
 }
 
 gfx::NativeCursor WebContentsViewAura::GetCursor(const gfx::Point& point) {
   return gfx::kNullCursor;
@@ skipping 142 matching lines @@
     OnDragEntered(event);
 
   web_contents_->GetRenderViewHost()->DragTargetDrop(
       event.location(),
       gfx::Screen::GetCursorScreenPoint(),
       ConvertAuraEventFlagsToWebInputEventModifiers(event.flags()));
   if (drag_dest_delegate_)
     drag_dest_delegate_->OnDrop();
   return current_drag_op_;
 }