Support sequence<T> as native bindings arguments.

lib/html/scripts/systemnative.py

 #!/usr/bin/python
 # Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 # for details. All rights reserved. Use of this source code is governed by a
 # BSD-style license that can be found in the LICENSE file.
 
 """This module provides shared functionality for the systems to generate
 native binding from the IDL database."""
 
 import emitter
 import os
@@ skipping 807 matching lines @@
           '        if (!scriptArguments)\n'
           '            goto fail;\n'
           '        RefPtr<ScriptCallStack> scriptCallStack(DartUtilities::createScriptCallStack());\n'
           '        if (!scriptCallStack->size())\n'
           '            return;\n',
           INDEX=len(arguments) + 1)
 
     # Emit arguments.
     start_index = 1 if needs_receiver else 0
     for i, argument in enumerate(arguments):
+      type_info = self._TypeInfo(argument.type.id)
       argument_expression_template, type, cls, function = \
-          self._TypeInfo(argument.type.id).to_native_info(argument, self._interface.id)
+          type_info.to_native_info(argument, self._interface.id)
 
       if ((IsOptional(argument) and not self._IsArgumentOptionalInWebCore(node, argument)) or
           (argument.ext_attrs.get('Optional') == 'DefaultIsNullString')):
         function += 'WithNullCheck'
 
       argument_name = DartDomNameOfAttribute(argument)
+      if type_info.pass_native_by_ref():
+        invocation_template =\
+            '        $TYPE $ARGUMENT_NAME;\n'\

[podivilov, 2012/09/14 08:06:06]

nit: unnecessary trailing \

[Anton Muhin, 2012/09/14 12:32:58]

No, it's necessary.  Another option would be to put it into (), but I'd rather
keep as is.

+            '        $CLS::$FUNCTION($ARGUMENT_NAME, Dart_GetNativeArgument(args, $INDEX), exception);\n'

[podivilov, 2012/09/14 08:06:06]

nit: Dart_GetNativeArgument should come first.

[Anton Muhin, 2012/09/14 12:32:58]

Done.

+      else:
+        invocation_template =\
+            '        $TYPE $ARGUMENT_NAME = $CLS::$FUNCTION(Dart_GetNativeArgument(args, $INDEX), exception);\n'
       body_emitter.Emit(
-          '\n'
-          '        $TYPE $ARGUMENT_NAME = $CLS::$FUNCTION(Dart_GetNativeArgument(args, $INDEX), exception);\n'
+          '\n' +
+          invocation_template +
           '        if (exception)\n'
           '            goto fail;\n',
           TYPE=type,
           ARGUMENT_NAME=argument_name,
           CLS=cls,
           FUNCTION=function,
           INDEX=start_index + i)
       self._cpp_impl_includes.add('"%s.h"' % cls)
       cpp_arguments.append(argument_expression_template % argument_name)
 
@@ skipping 105 matching lines @@
     parent_interface = _FindInHierarchy(database, parent_interface, test)
     if parent_interface:
       return parent_interface
 
 def _ToWebKitName(name):
   name = name[0].lower() + name[1:]
   name = re.sub(r'^(hTML|uRL|jS|xML|xSLT)', lambda s: s.group(1).lower(),
                 name)
   return re.sub(r'^(create|exclusive)', lambda s: 'is' + s.group(1).capitalize(),
                 name)