Lazy peer API.

runtime/vm/dart_api_impl.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "include/dart_api.h"
 
 #include "vm/bigint_operations.h"
 #include "vm/class_finalizer.h"
 #include "vm/compiler.h"
 #include "vm/dart.h"
@@ skipping 4426 matching lines @@
 
 DART_EXPORT void Dart_InitPerfEventsSupport(Dart_FileWriterFunction function) {
   Dart::set_perf_events_writer(function);
 }
 
 
 DART_EXPORT void Dart_InitFlowGraphPrinting(Dart_FileWriterFunction function) {
   Dart::set_flow_graph_writer(function);
 }
 
+
+// --- Peer support ---
+
+
+DART_EXPORT Dart_Handle Dart_GetPeer(Dart_Handle object, void** peer) {
+  if (peer == NULL) {
+    RETURN_NULL_ERROR(peer);
+  }
+  Isolate* isolate = Isolate::Current();
+  const Object& obj = Object::Handle(isolate, Api::UnwrapHandle(object));

[Anton Muhin, 2012/10/10 14:54:08]

isn't DARTSCOPE(isolate) missing here and in the second method?

[siva, 2012/10/10 15:01:28]

Yes.

And a test case that will exercise a path where we do not implicitly set up
Zone/Handlescope.

Thanks for catching that.

On 2012/10/10 14:54:08, Anton Muhin wrote:

[cshapiro, 2012/10/10 16:39:07]

Thanks.  I will add that today to both GetPeer and SetPeer.

+  if (obj.IsNull() || obj.IsNumber() || obj.IsBool()) {
+    const char* msg =
+        "%s: argument 'object' cannot be a subtype of Null, num, or bool";
+    return Api::NewError(msg, CURRENT_FUNC);
+  }
+  {
+    NoGCScope no_gc;
+    RawObject* raw_obj = obj.raw();
+    *peer = isolate->heap()->GetPeer(raw_obj);
+  }
+  return Api::Success(isolate);
+}
+
+
+DART_EXPORT Dart_Handle Dart_SetPeer(Dart_Handle object, void* peer) {
+  Isolate* isolate = Isolate::Current();
+  const Object& obj = Object::Handle(isolate, Api::UnwrapHandle(object));
+  if (obj.IsNull() || obj.IsNumber() || obj.IsBool()) {
+    const char* msg =
+        "%s: argument 'object' cannot be a subtype of Null, num, or bool";
+    return Api::NewError(msg, CURRENT_FUNC);
+  }
+  {
+    NoGCScope no_gc;
+    RawObject* raw_obj = obj.raw();
+    isolate->heap()->SetPeer(raw_obj, peer);
+  }
+  return Api::Success(isolate);
+}
+
 }  // namespace dart