Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(744)

Side by Side Diff: ash/resources/PRESUBMIT.py

Issue 10905242: add ash_resources.grd and necessary changes to use images in ash/resources (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: presubmit.py Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « ash/launcher/tabbed_launcher_button.cc ('k') | ash/resources/ash_resources.grd » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Presubmit script for Chromium theme resources. 5 """Presubmit script for ash Chromium Ash resources.
flackr 2012/09/13 17:52:25 ash Chromium Ash?
6 6
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
8 for more details about the presubmit API built into gcl/git cl, and see 8 for more details about the presubmit API built into gcl/git cl, and see
9 http://www.chromium.org/developers/web-development-style-guide for the rules 9 http://www.chromium.org/developers/web-development-style-guide for the rules
10 we're checking against here. 10 we're checking against here.
11 """ 11 """
12 12
13 13
14 def CheckChangeOnUpload(input_api, output_api): 14 def CheckChangeOnUpload(input_api, output_api):
15 return _CommonChecks(input_api, output_api) 15 return _CommonChecks(input_api, output_api)
16 16
17 17
18 def CheckChangeOnCommit(input_api, output_api): 18 def CheckChangeOnCommit(input_api, output_api):
19 return _CommonChecks(input_api, output_api) 19 return _CommonChecks(input_api, output_api)
20 20
21 21
22 def _CommonChecks(input_api, output_api): 22 def _CommonChecks(input_api, output_api):
23 """Checks common to both upload and commit.""" 23 """Checks common to both upload and commit."""
24 results = [] 24 results = []
25 resources = input_api.os_path.join(input_api.PresubmitLocalPath(), 25 resources = input_api.os_path.join(input_api.PresubmitLocalPath(),
26 '../../../ui/resources') 26 '../../ui/resources')
27 27
28 # List of paths with their associated scale factor. This is used to verify 28 # List of paths with their associated scale factor. This is used to verify
29 # that the images modified in one are the correct scale of the other. 29 # that the images modified in one are the correct scale of the other.
30 path_scales = [ 30 path_scales = [
31 [(100, 'default_100_percent/'), (200, 'default_200_percent/')], 31 [(100, 'default_100_percent/'), (200, 'default_200_percent/')],
32 ] 32 ]
33 33
34 import sys 34 import sys
35 old_path = sys.path 35 old_path = sys.path
36 36
37 try: 37 try:
38 sys.path = [resources] + old_path 38 sys.path = [resources] + old_path
39 from resource_check import resource_scale_factors 39 from resource_check import resource_scale_factors
40 40
41 for paths in path_scales: 41 for paths in path_scales:
42 results.extend(resource_scale_factors.ResourceScaleFactors( 42 results.extend(resource_scale_factors.ResourceScaleFactors(
43 input_api, output_api, paths).RunChecks()) 43 input_api, output_api, paths).RunChecks())
44 finally: 44 finally:
45 sys.path = old_path 45 sys.path = old_path
46 46
47 return results 47 return results
OLDNEW
« no previous file with comments | « ash/launcher/tabbed_launcher_button.cc ('k') | ash/resources/ash_resources.grd » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698