Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Unified Diff: media/filters/chunk_demuxer.h

Issue 10905236: Move ChunkDemuxer handling from WMPProxy to WMPI and remove ChunkDemuxerClient (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix ffmpeg_regression_tests Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/filters/chunk_demuxer.h
diff --git a/media/filters/chunk_demuxer.h b/media/filters/chunk_demuxer.h
index a6118497ea35c41aa64d08236e5689f600ff4677..77cebc25faa3b57b19d3035851c02ae4df1fee28 100644
--- a/media/filters/chunk_demuxer.h
+++ b/media/filters/chunk_demuxer.h
@@ -19,7 +19,6 @@
namespace media {
-class ChunkDemuxerClient;
class ChunkDemuxerStream;
class FFmpegURLProtocol;
@@ -33,7 +32,10 @@ class MEDIA_EXPORT ChunkDemuxer : public Demuxer {
kReachedIdLimit, // Reached ID limit. We can't handle any more IDs.
};
- explicit ChunkDemuxer(ChunkDemuxerClient* client);
+ typedef base::Callback<void(scoped_array<uint8> init_data,
+ int init_data_size)> NeedKeyCB;
+
+ ChunkDemuxer(const base::Closure& open_cb, const NeedKeyCB& need_key_cb);
Ami GONE FROM CHROMIUM 2012/09/12 18:45:34 doco when callbacks are called
Ami GONE FROM CHROMIUM 2012/09/12 18:45:34 is it easy to see why these are not needed in Demu
acolwell GONE FROM CHROMIUM 2012/09/12 22:03:53 Done.
acolwell GONE FROM CHROMIUM 2012/09/12 22:03:53 Eventually I believe the need_key_cb could be move
// Demuxer implementation.
virtual void Initialize(DemuxerHost* host,
@@ -160,7 +162,9 @@ class MEDIA_EXPORT ChunkDemuxer : public Demuxer {
State state_;
DemuxerHost* host_;
- ChunkDemuxerClient* client_;
+ base::Closure open_cb_;
+ NeedKeyCB need_key_cb_;
+
PipelineStatusCB init_cb_;
PipelineStatusCB seek_cb_;

Powered by Google App Engine
This is Rietveld 408576698