Add named constructor name checking

tests/language/bad_constructor_test.dart

Index: tests/language/bad_constructor_test.dart
===================================================================
--- tests/language/bad_constructor_test.dart	(revision 11907)
+++ tests/language/bad_constructor_test.dart	(working copy)
@@ -1,8 +1,8 @@
 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
+// VMOptions=--constructor_name_check

[ahe, 2012/09/06 08:54:26]

Please don't add VM specific options to shared language tests.

[Ivan Posva, 2012/09/06 09:12:50]

Would you rather have us break all of the users by not having the flag? We could
also print warnings by default instead.

[ahe, 2012/09/06 09:32:59]

That's a strange trade-off. You can have a VM-specific test suite. We do that
for dart2js. 

[Ivan Posva, 2012/09/06 10:39:01]

I think it makes perfect sense to have the tests that were added below in this
shared language test. Unless you pass the flag these will fail while we accept
the old behaviour, so I expect the flag to be removed once we have flipped the
default.

[hausner, 2012/09/06 16:18:38]

Yes, this flag goes away as soon as we enable the check by default.

There are other VM-specific flags in the language suite, this is not a first.
The test itself is not VM-specific, it applies to dart2js as well.

Another option to eliminate the flag and break some existing code.


On 2012/09/06 10:39:01, Ivan Posva wrote:

 
-
 class A {
   // Constructor may not be static.
   static A();  /// 00: compile-time error
@@ -15,6 +15,16 @@
 
   // Factory may not be abstract
   abstract factory A() { return null; }  /// 03: compile-time error
+
+  // Named constructor may not conflict with names of methods and fields.
+  var m;
+  A.m() { m = 0; }  /// 04: compile-time error
+
+  set q(var value) { m = q; }
+  A.q();   /// 05: compile-time error
+
+  int foo(int a, int b) => a + b * m;
+  A.foo() : m = 0;  /// 06: compile-time error

[siva, 2012/09/06 16:52:10]

We should add a test where the named constructor and field are flipped, e.g:

A.error() : ...
var error;  /// 07: compile-time error

[hausner, 2012/09/06 18:02:13]

Done.

 }
 
 main() {