Add is_fullscreen to video updates

ash/wm/mock_video_detector_observer.h

+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef ASH_WM_MOCK_VIDEO_DETECTOR_OBSERVER_H_
+#define ASH_WM_MOCK_VIDEO_DETECTOR_OBSERVER_H_
+
+#include "ash/wm/video_detector.h"
+
+#include <gmock/gmock.h>
+#include <gtest/gtest.h>
+
+namespace ash {
+
+class MockVideoDetectorObserver : public VideoDetectorObserver {

[Daniel Erat, 2012/08/30 20:33:59]

i dislike gmock (i think that its code is hard to read, and that it spams logs,
and that it often encourages testing of minutia of behavior that we don't
actually care about).  that said, the use here seems legitimate (you're testing
whether the fullscreen parameter is true or not).

beng@ points out that there's no use of gmock in ash currently and suggests that
he'd like to keep things that way.  would you object to tracking the number of
fullscreen/non-fullscreen calls in the existing mock class instead of adding a
gmock implementation?

[rharrison, 2012/08/31 18:57:13]

Since the preference is to not use it I am fine with changing this.

+ public:
+  MOCK_METHOD1(OnVideoDetected,
+      void(bool is_fullscreen));
+  void ExpectOnVideoDetected(bool is_fullscreen) {
+    EXPECT_CALL(*this, OnVideoDetected(is_fullscreen))
+                .Times(1)
+                .RetiresOnSaturation();
+  }
+};  // class MockVideoDetectorObserver
+
+}  // namespace ash
+
+#endif  // ASH_WM_MOCK_VIDEO_DETECTOR_OBSERVER_H_