chrome/test/data/extensions/manifest_tests/browser_action_invalid_default_icons.json - Issue 10905005: Change browser/page action default icon defined in manifest to support hidpi.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/extensions/manifest_tests/browser_action_invalid_default_icons.json

Issue 10905005: Change browser/page action default icon defined in manifest to support hidpi. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: minor cleanup Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/test/data/extensions/api_test/browser_action/no_icon/manifest.json ('k') | chrome/test/data/extensions/manifest_tests/browser_action_no_default_properties.json » ('j') | ui/gfx/image/image_skia_operations.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/extensions/manifest_tests/browser_action_invalid_default_icons.json

diff --git a/chrome/test/data/extensions/manifest_tests/browser_action_invalid_default_icons.json b/chrome/test/data/extensions/manifest_tests/browser_action_invalid_default_icons.json

new file mode 100644

index 0000000000000000000000000000000000000000..001c8453e6a7550c46e0dba4822d4c4b08687cc8

--- /dev/null

+++ b/chrome/test/data/extensions/manifest_tests/browser_action_invalid_default_icons.json

@@ -0,0 +1,14 @@

+ "manifest_version": 2,

+ "name": "my extension",

+ "version": "1.0.0.0",

+ "description": "Browser actin with a default icon set.",

+ "browser_action": {

+ "default_icon": "",

+ "default_icon_set": {

+ "19": "",

+ "24": "icon24.png",

+ "38": "icon38.png"

+ }