chrome/common/extensions/docs/server2/templates/intros/pageAction.html - Issue 10905005: Change browser/page action default icon defined in manifest to support hidpi.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/docs/server2/templates/intros/pageAction.html

Issue 10905005: Change browser/page action default icon defined in manifest to support hidpi. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/gtk/location_bar_view_gtk.h ('K') | « chrome/common/extensions/docs/server2/templates/intros/browserAction.html ('k') | chrome/common/extensions/extension.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/docs/server2/templates/intros/pageAction.html

diff --git a/chrome/common/extensions/docs/server2/templates/intros/pageAction.html b/chrome/common/extensions/docs/server2/templates/intros/pageAction.html

index 86930f1715fe78be0d05c662fc3ff0559d97d957..e284caafa66d08af5a308d23fc265606086f99bf 100644

--- a/chrome/common/extensions/docs/server2/templates/intros/pageAction.html

+++ b/chrome/common/extensions/docs/server2/templates/intros/pageAction.html

@@ -43,9 +43,29 @@ like this:

"name": "My extension",

...

"page_action": {

- "default_icon": "icons/foo.png", // optional

- "default_title": "Do action", // optional; shown in tooltip

- "default_popup": "popup.html" // optional

+ "default_icon": { // optional

+ "19": "images/icon19.png", // optional

+ "38": "images/icon38.png" // optional

+ },

+ "default_title": "Google Mail", // optional; shown in tooltip

+ "default_popup": "popup.html" // optional

+ },

+ ...

+}</pre>

+

+If you don't care about icon appearance when screens's device-independent

+pixel (dip) size is different than its physical pixel size, you can register

+the default icon like this:

+

+<pre>{

+ "name": "My extension",

+ ...

+ "page_action": {

+ ...

+ "default_icon": "images/icon19.png" // optional

+ // equal to "default_icon": { "19": "images/icon19.png" }

},

...

}</pre>

@@ -105,4 +125,4 @@ You can find simple examples of using page actions in the

directory.

For other examples and for help in viewing the source code, see

<a href="samples.html">Samples</a>.

-

+