Issue 10905: Unfork test_shell_main_gtk back into test_shell_main.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10905: Unfork test_shell_main_gtk back into test_shell_main. (Closed)

Created:
12 years, 1 month ago by Elliot Glaysher

Modified:
9 years, 7 months ago

Reviewers:
tony, Evan Martin

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Unfork test_shell_main_gtk back into test_shell_main. Still doesn't run layout tests, but it's unforked and runs.

Patch Set 1 #

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+65 lines, -86 lines)			Patch
M	base/file_util_linux.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	base/process_util_linux.cc	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	webkit/tools/test_shell/SConscript	View	1 chunk	+1 line, -1 line	1 comment	Download
M	webkit/tools/test_shell/test_shell_main.cc	View	15 chunks	+55 lines, -8 lines	2 comments	Download
M	webkit/tools/test_shell/test_shell_main_gtk.cc	View	1 chunk	+0 lines, -77 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

tony

12 years, 1 month ago (2008-11-13 22:21:15 UTC) #2

LGTM.  I think this is ok for now, but going forward, we should try to create
platform specific functions to handle these in the platform files rather than
all the #ifdefs.  E.g., you could imagine TestShell::InitFonts or
TestShell::InitDefaultTheme that get defined in test_shell_*.cc.

http://codereview.chromium.org/10905/diff/1/4
File webkit/tools/test_shell/SConscript (right):

http://codereview.chromium.org/10905/diff/1/4#newcode145
Line 145: 'test_shell_main.cc',
Nit: Can we remove this and the one 5 lines above and put it into the main
input_files section?

http://codereview.chromium.org/10905/diff/1/5
File webkit/tools/test_shell/test_shell_main.cc (right):

http://codereview.chromium.org/10905/diff/1/5#newcode363
Line 363: cerr << "Watching for urls!" << endl;
Nit: Can you remove this or turn it into DLOG(INFO)?

http://codereview.chromium.org/10905/diff/1/5#newcode368
Line 368: cerr << "newLine: " << newLine << endl;
Same as above.

Expand Messages | Collapse Messages