Switch from using an iframe to using a JSON URL and dynamically generating th...

Switch from using an iframe to using a JSON URL and dynamically generating the content.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=16135

[Erik does not do reviews, 2009-05-15 00:12:17]

there are a couple of bugs remaining here:
- there's a placeholder button for the per-user data feature (not yet
implemented)
- switching from an iframe to inline content seems to have messed up the width
changing (it shrinks and then expands at the end)

[Aaron Boodman, 2009-05-15 00:15:17]

lgtm

http://codereview.chromium.org/109031/diff/2003/3001
File chrome/test/data/extensions/samples/buildbot/buildbot.html (right):

http://codereview.chromium.org/109031/diff/2003/3001#newcode17
Line 17: console.log("Error: couldn't find status div");
It's more traditional to just:

throw new Error("...")

That will show up in the console, red, and then you don't have to return.

http://codereview.chromium.org/109031/diff/2003/3001#newcode43
Line 43: if (window.JSON) {
I think we should always have window.JSON now, right?

http://codereview.chromium.org/109031/diff/3005/2005#newcode3
Line 3: var botRoot = "http://hae14.jail:8016";
Can you remove this internal URL?

http://codereview.chromium.org/109031/diff/3005/2005#newcode234
Line 234: 
Can we just remove this bit for now if it doesn't work yet?

[Erik does not do reviews, 2009-05-15 00:44:53]

fixed and committed