Issue 109026: Add inferred function name to the json protocol

Issue 109026: Add inferred function name to the json protocol (Closed)

Created:
11 years, 7 months ago by yurys

Modified:
9 years, 7 months ago

Reviewers:
Søren Thygesen Gjesse

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Add function inferred name to FunctionMirror and its json representation. Committed: http://code.google.com/p/v8/source/detail?r=1871

Patch Set 3 : '' #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+54 lines, -14 lines)			Patch
M	src/mirror-delay.js	View	1 2	3 chunks	+18 lines, -0 lines	0 comments	Download
M	src/runtime.h	View	1 2	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/runtime.cc	View	1 2	1 chunk	+9 lines, -0 lines	0 comments	Download
M	test/mjsunit/debug-backtrace.js	View	1	4 chunks	+23 lines, -13 lines	0 comments	Download
M	test/mjsunit/mirror-unresolved-function.js	View	1 2	2 chunks	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Søren Thygesen Gjesse

LGTM with a few comments. http://codereview.chromium.org/109026/diff/1008/1013 File src/mirror-delay.js (right): http://codereview.chromium.org/109026/diff/1008/1013#newcode762 Line 762: FunctionMirror.prototype.inferred_name = function() ...

11 years, 7 months ago (2009-05-05 17:12:16 UTC) #2

yurys

11 years, 7 months ago (2009-05-05 18:10:45 UTC) #3

http://codereview.chromium.org/109026/diff/1008/1013
File src/mirror-delay.js (right):

http://codereview.chromium.org/109026/diff/1008/1013#newcode762
Line 762: FunctionMirror.prototype.inferred_name = function() {
On 2009/05/05 17:12:17, Søren Gjesse wrote:
> inferred_name -> inferredName

Done.

http://codereview.chromium.org/109026/diff/1008/1013#newcode870
Line 870: return '';
On 2009/05/05 17:12:17, Søren Gjesse wrote:
> Please return undefined.

Done.

http://codereview.chromium.org/109026/diff/1008/1013#newcode1852
Line 1852: content.push(MakeJSONPair_('inferredName',
On 2009/05/05 17:12:17, Søren Gjesse wrote:
> Add if (!IS_UNDEFINED(mirror.inferredName()) ...

Done.

http://codereview.chromium.org/109026/diff/1008/1011
File src/runtime.cc (right):

http://codereview.chromium.org/109026/diff/1008/1011#newcode1103
Line 1103: static Object* Runtime_FunctionGetInferredName(Arguments args) {
On 2009/05/05 17:12:17, Søren Gjesse wrote:
> Move to the #ifdef ENABLE_DEBUGGER_SUPPORT section below.

Done.

http://codereview.chromium.org/109026/diff/1008/1012
File src/runtime.h (right):

http://codereview.chromium.org/109026/diff/1008/1012#newcode163
Line 163: F(FunctionGetInferredName, 1) \
On 2009/05/05 17:12:17, Søren Gjesse wrote:
> Move this to the debugger section below (inside #ifdef
ENABLE_DEBUGGER_SUPPORT)

Done.

Expand Messages | Collapse Messages