Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 109025: Have the profiler load the correct registers on x64. (Closed)

Created:
11 years, 7 months ago by Dean McNamee
Modified:
9 years, 7 months ago
Reviewers:
Lasse Reichstein
CC:
v8-dev
Visibility:
Public.

Description

Have the profiler load the correct registers on x64. This is still not correct, since internally they are kept as an int. Use our new V8_HOST_ARCH macros for detecting the host processor.

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -5 lines) Patch
M src/platform-linux.cc View 1 chunk +9 lines, -5 lines 2 comments Download

Messages

Total messages: 3 (0 generated)
Dean McNamee
11 years, 7 months ago (2009-05-05 15:31:26 UTC) #1
Lasse Reichstein
LGTM http://codereview.chromium.org/109025/diff/1/2 File src/platform-linux.cc (right): http://codereview.chromium.org/109025/diff/1/2#newcode608 Line 608: sample.pc = mcontext.gregs[REG_RIP]; Does the assignment compile, ...
11 years, 7 months ago (2009-05-06 11:05:27 UTC) #2
Dean McNamee
11 years, 7 months ago (2009-05-06 11:07:15 UTC) #3
http://codereview.chromium.org/109025/diff/1/2
File src/platform-linux.cc (right):

http://codereview.chromium.org/109025/diff/1/2#newcode608
Line 608: sample.pc = mcontext.gregs[REG_RIP];
It does compile, but I'll just do UNIMPLEMENTED :\

On 2009/05/06 11:05:27, Lasse Reichstein wrote:
> Does the assignment compile, and throw away the upper half of the value
> silently? If so, I'd prefer an UNIMPLEMENTED() in front of it with a comment
> saying to not remove it unitl sample.pc allows 64 bits.

Powered by Google App Engine
This is Rietveld 408576698