Issue 109021: Add a temporary hack to FmtElm to truncate 64-bit pointers to 32-bits.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 109021: Add a temporary hack to FmtElm to truncate 64-bit pointers to 32-bits. (Closed)

Created:
11 years, 7 months ago by Dean McNamee

Modified:
9 years, 7 months ago

Reviewers:
Lasse Reichstein

CC:
v8-dev

Visibility:
Public.

Description

Add a temporary hack to FmtElm to truncate 64-bit pointers to 32-bits. We will have to do some more work to get the code to handle pointers correctly. Also clean up the constructors, and reduce the long lines.

Patch Set 1 #

Patch Set 2 : Fix indention #

Total comments: 1

Patch Set 3 : UNIMPLEMENTED #

Patch Set 4 : Merge #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -7 lines)			Patch
	M	src/string-stream.h	View	1 2	1 chunk	+30 lines, -7 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein

11 years, 7 months ago (2009-05-05 14:20:49 UTC) #2

LGTM.

http://codereview.chromium.org/109021/diff/2001/1002
File src/string-stream.h (right):

http://codereview.chromium.org/109021/diff/2001/1002#newcode99
Line 99: data_.u_int_ = reinterpret_cast<intptr_t>(value) & 0xffffffff;
Just put an UNIMPLEMENTED() macro here instead. I prefer things that don't work
at all to things that doesn't work right. They are easier to find.

Expand Messages | Collapse Messages