Issue 109020: X64 adaption: Changed a constant from kBitsPerPointer to kBitsPerInt.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 109020: X64 adaption: Changed a constant from kBitsPerPointer to kBitsPerInt. (Closed)

Created:
11 years, 7 months ago by Lasse Reichstein

Modified:
9 years, 6 months ago

Reviewers:
Dean McNamee

CC:
v8-dev

Visibility:
Public.

Description

X64 adaption: Changed a constant from kBitsPerPointer to kBitsPerInt. Still stays within the size of Smi and works with a uint32_t bitfield. Bitfield might need to be extended to handle a larger base.

Patch Set 1 #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/code-stubs.h	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Dean McNamee

11 years, 7 months ago (2009-05-05 13:18:43 UTC) #2

On 2009/05/05 13:13:29, Lasse Reichstein wrote:
> QUick review.

LG if you think that these should still be 32-bit ints on 64-bit.

Expand Messages | Collapse Messages