Issue 109017: Use our own macros for 64-bit constants.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 109017: Use our own macros for 64-bit constants. (Closed)

Created:
11 years, 7 months ago by Dean McNamee

Modified:
9 years, 7 months ago

Reviewers:
Lasse Reichstein

CC:
v8-dev

Visibility:
Public.

Description

Use our own macros for 64-bit constants.

Patch Set 1 #

Total comments: 1

Patch Set 2 : Remove setting of __STDC_CONSTANT_MACROS. #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -9 lines)			Patch
	M	include/v8.h	View		1 chunk	+1 line, -3 lines	0 comments	Download
	M	src/globals.h	View		2 chunks	+11 lines, -6 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein

LGTM, with comments. http://codereview.chromium.org/109017/diff/1/2 File src/globals.h (right): http://codereview.chromium.org/109017/diff/1/2#newcode61 Line 61: #define V8_INT64_C(x) (x ## LL) ...

11 years, 7 months ago (2009-05-05 10:17:15 UTC) #2

long long is 64-bit in both 32 and 64-bit.

Expand Messages | Collapse Messages