Issue 109015: Revert workaround for http://crbug.com/9746.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 109015: Revert workaround for http://crbug.com/9746. (Closed)

Created:
11 years, 7 months ago by Mads Ager (chromium)

Modified:
9 years, 7 months ago

Reviewers:
iposva, Kasper Lund

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Revert workaround for http://crbug.com/9746. Committed: http://code.google.com/p/v8/source/detail?r=1860

Patch Set 2 : '' #

Created: 11 years, 7 months ago

	Unified diffs	Side-by-side diffs	Stats (+10 lines, -92 lines)
M	src/objects.cc	View	6 chunks	+3 lines, -40 lines	0 comments
M	test/cctest/test-debug.cc	View	1 chunk	+1 line, -1 line	0 comments
M	test/cctest/test-strings.cc	View	3 chunks	+6 lines, -51 lines	0 comments

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Kasper Lund

LGTM. http://codereview.chromium.org/109015/diff/1/2 File test/cctest/test-strings.cc (right): http://codereview.chromium.org/109015/diff/1/2#newcode397 Line 397: if (destructed_ != NULL) { Get rid ...

11 years, 7 months ago (2009-05-05 10:09:11 UTC) #2

Mads Ager (chromium)

Fixed const char issue in test-debug in the same go. http://codereview.chromium.org/109015/diff/1/2 File test/cctest/test-strings.cc (right): http://codereview.chromium.org/109015/diff/1/2#newcode397 ...

11 years, 7 months ago (2009-05-05 10:15:29 UTC) #3

LGTM.

Thanks!
-Ivan

Expand Messages | Collapse Messages

Issue 109015: Revert workaround for http://crbug.com/9746. (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Messages