Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(505)

Issue 109013: Add the ability to set embedder data on created contexts from the API (Closed)

Created:
11 years, 7 months ago by Søren Thygesen Gjesse
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Add the ability to set embedder data on created contexts from the API. Expose the active context where a break event occoured through the debug message handler. Committed: http://code.google.com/p/v8/source/detail?r=1857

Patch Set 1 #

Total comments: 4

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+145 lines, -2 lines) Patch
M include/v8.h View 1 1 chunk +8 lines, -0 lines 0 comments Download
M src/api.cc View 1 1 chunk +34 lines, -0 lines 0 comments Download
M src/bootstrapper.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/contexts.h View 2 chunks +3 lines, -1 line 0 comments Download
M src/debug.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/debug.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-debug.cc View 2 chunks +93 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Søren Thygesen Gjesse
This is the first of a series of changes to provide more information on the ...
11 years, 7 months ago (2009-05-05 09:09:47 UTC) #1
Christian Plesner Hansen
Lgtm. A general comment: I've been using the name 'Data' pretty consistently, the same way ...
11 years, 7 months ago (2009-05-05 09:19:06 UTC) #2
Søren Thygesen Gjesse
11 years, 7 months ago (2009-05-05 09:32:01 UTC) #3
As discussed offline changing Data to UserData is th right thing to do. However
it should be changed consistently in all places at some point.

http://codereview.chromium.org/109013/diff/1/3
File include/v8.h (right):

http://codereview.chromium.org/109013/diff/1/3#newcode2268
Line 2268: Handle<Value> GetData();
On 2009/05/05 09:19:07, Christian Plesner Hansen wrote:
> If it returns a local handle consider using the type Local<Value> instead.

Done.

http://codereview.chromium.org/109013/diff/1/4
File src/api.cc (right):

http://codereview.chromium.org/109013/diff/1/4#newcode451
Line 451: {
On 2009/05/05 09:19:07, Christian Plesner Hansen wrote:
> Why the inner scope?

To avoid adding the "env" handle to the outer scope.

Powered by Google App Engine
This is Rietveld 408576698