Issue 109004: Suggestion for 1717.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 109004: Suggestion for 1717. (Closed)

Created:
11 years, 7 months ago by Erik Corry

Modified:
9 years, 7 months ago

Reviewers:
Kasper Lund

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Fix Chromium bug 1717 by emulating JSCs somewhat strange hidden prototypes on some built in types. Committed: http://code.google.com/p/v8/source/detail?r=1882

Patch Set 3 : '' #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+252 lines, -19 lines)			Patch
M	src/array.js	View	1 2	3 chunks	+2 lines, -4 lines	0 comments	Download
M	src/bootstrapper.cc	View	2	1 chunk	+7 lines, -3 lines	0 comments	Download
M	src/date-delay.js	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	src/math.js	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	src/runtime.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/runtime.cc	View	1 2	3 chunks	+58 lines, -9 lines	0 comments	Download
M	src/string.js	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
A	test/mjsunit/undeletable-functions.js	View	2	1 chunk	+181 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Kasper Lund

LGTM. Are you sure JSC passes the test cases? http://codereview.chromium.org/109004/diff/1002/1009 File src/bootstrapper.cc (right): http://codereview.chromium.org/109004/diff/1002/1009#newcode1478 Line ...

11 years, 7 months ago (2009-05-05 14:04:08 UTC) #2

Kasper Lund

11 years, 7 months ago (2009-05-06 05:46:33 UTC) #3

Yet another comment:

http://codereview.chromium.org/109004/diff/1002/1006
File src/array.js (right):

http://codereview.chromium.org/109004/diff/1002/1006#newcode1013
Line 1013: InstallFunctions(hidden_prototype, DONT_ENUM, $Array(
How about creating a JavaScript function that encapsulates this hidden prototype
and InstallFunctions stuff? You end up doing it in a lot of different places.

Expand Messages | Collapse Messages

Issue 109004: Suggestion for 1717. (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Messages