Issue 109003: Add regression test case for crbug.com/9746.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 109003: Add regression test case for crbug.com/9746. (Closed)

Created:
11 years, 7 months ago by Kasper Lund

Modified:
9 years, 7 months ago

Reviewers:
Kevin Millikin (Chromium), Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Add regression test case for crbug.com/9746. Committed: http://code.google.com/p/v8/source/detail?r=1851

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+101 lines, -4 lines)			Patch
	M	test/cctest/test-strings.cc	View	1	4 chunks	+101 lines, -4 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

Funky stuff, thanks for creating the test case! LGTM

11 years, 7 months ago (2009-05-05 06:58:46 UTC) #2

Kevin Millikin (Chromium)

11 years, 7 months ago (2009-05-05 08:12:59 UTC) #3

Good.

http://codereview.chromium.org/109003/diff/1004/1005
File test/cctest/test-strings.cc (right):

http://codereview.chromium.org/109003/diff/1004/1005#newcode503
Line 503: while (Heap::InNewSpace(*slice)) {
This will probably terminate :)

http://codereview.chromium.org/109003/diff/1004/1005#newcode517
Line 517: // get its wrapper. This allocated yet another weak handle that
"allocated" => "allocates"

Expand Messages | Collapse Messages