Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(729)

Side by Side Diff: src/liveedit.h

Issue 1090003: LiveEdit: update breakpoint positions for non-changed functions (Closed)
Patch Set: follow codereview Created 10 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/debug-debugger.js ('k') | src/liveedit.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2010 the V8 project authors. All rights reserved. 1 // Copyright 2010 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 70 matching lines...) Expand 10 before | Expand all | Expand 10 after
81 Handle<String> source); 81 Handle<String> source);
82 82
83 static void WrapSharedFunctionInfos(Handle<JSArray> array); 83 static void WrapSharedFunctionInfos(Handle<JSArray> array);
84 84
85 static void ReplaceFunctionCode(Handle<JSArray> new_compile_info_array, 85 static void ReplaceFunctionCode(Handle<JSArray> new_compile_info_array,
86 Handle<JSArray> shared_info_array); 86 Handle<JSArray> shared_info_array);
87 87
88 static void RelinkFunctionToScript(Handle<JSArray> shared_info_array, 88 static void RelinkFunctionToScript(Handle<JSArray> shared_info_array,
89 Handle<Script> script_handle); 89 Handle<Script> script_handle);
90 90
91 static void PatchFunctionPositions(Handle<JSArray> shared_info_array, 91 // Returns an array of pairs (new source position, breakpoint_object/array)
92 Handle<JSArray> position_change_array); 92 // so that JS side could update positions in breakpoint objects.
93 static Handle<JSArray> PatchFunctionPositions(
94 Handle<JSArray> shared_info_array, Handle<JSArray> position_change_array);
93 95
94 // Checks listed functions on stack and return array with corresponding 96 // Checks listed functions on stack and return array with corresponding
95 // FunctionPatchabilityStatus statuses; extra array element may 97 // FunctionPatchabilityStatus statuses; extra array element may
96 // contain general error message. Modifies the current stack and 98 // contain general error message. Modifies the current stack and
97 // has restart the lowest found frames and drops all other frames above 99 // has restart the lowest found frames and drops all other frames above
98 // if possible and if do_drop is true. 100 // if possible and if do_drop is true.
99 static Handle<JSArray> CheckAndDropActivations( 101 static Handle<JSArray> CheckAndDropActivations(
100 Handle<JSArray> shared_info_array, bool do_drop); 102 Handle<JSArray> shared_info_array, bool do_drop);
101 103
102 // A copy of this is in liveedit-debugger.js. 104 // A copy of this is in liveedit-debugger.js.
103 enum FunctionPatchabilityStatus { 105 enum FunctionPatchabilityStatus {
104 FUNCTION_AVAILABLE_FOR_PATCH = 1, 106 FUNCTION_AVAILABLE_FOR_PATCH = 1,
105 FUNCTION_BLOCKED_ON_ACTIVE_STACK = 2, 107 FUNCTION_BLOCKED_ON_ACTIVE_STACK = 2,
106 FUNCTION_BLOCKED_ON_OTHER_STACK = 3, 108 FUNCTION_BLOCKED_ON_OTHER_STACK = 3,
107 FUNCTION_BLOCKED_UNDER_NATIVE_CODE = 4, 109 FUNCTION_BLOCKED_UNDER_NATIVE_CODE = 4,
108 FUNCTION_REPLACED_ON_ACTIVE_STACK = 5 110 FUNCTION_REPLACED_ON_ACTIVE_STACK = 5
109 }; 111 };
110 }; 112 };
111 113
112 #endif // ENABLE_DEBUGGER_SUPPORT 114 #endif // ENABLE_DEBUGGER_SUPPORT
113 115
114 116
115 } } // namespace v8::internal 117 } } // namespace v8::internal
116 118
117 #endif /* V*_LIVEEDIT_H_ */ 119 #endif /* V*_LIVEEDIT_H_ */
OLDNEW
« no previous file with comments | « src/debug-debugger.js ('k') | src/liveedit.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698