Introduce App Launcher for Windows.

chrome/browser/ui/views/app_list/app_list_controller_win.cc

Index: chrome/browser/ui/views/app_list/app_list_controller_win.cc
diff --git a/chrome/browser/ui/views/app_list/app_list_controller_win.cc b/chrome/browser/ui/views/app_list/app_list_controller_win.cc
new file mode 100644
index 0000000000000000000000000000000000000000..3666560a31b6b88be114b5ad20d949df85e37e6c
--- /dev/null
+++ b/chrome/browser/ui/views/app_list/app_list_controller_win.cc
@@ -0,0 +1,103 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "base/lazy_instance.h"
+#include "chrome/browser/extensions/extension_service.h"
+#include "chrome/browser/profiles/profile.h"
+#include "chrome/browser/ui/app_list/app_list_controller.h"
+#include "chrome/browser/ui/app_list/app_list_view_delegate.h"
+#include "chrome/browser/ui/extensions/application_launch.h"
+#include "grit/theme_resources.h"
+#include "ui/app_list/app_list_view.h"
+#include "ui/app_list/icon_cache.h"
+#include "ui/app_list/pagination_model.h"
+#include "ui/base/resource/resource_bundle.h"
+#include "ui/base/win/shell.h"
+#include "ui/views/bubble/bubble_border.h"
+#include "ui/views/widget/widget.h"
+
+namespace {

[msw, 2012/08/29 08:02:35]

nit: blank lines inside namespace braces, here and lines 83, 85, and 103.

[benwells, 2012/08/30 06:51:30]

Done.

+  const wchar_t kAppListAppId[] = L"ChromeAppList";

[xiyuan, 2012/08/29 17:39:15]

nit: After insert blank line above, shift two-space left to make the line starts
at col 0.

[benwells, 2012/08/30 06:51:30]

Done.

+  const gfx::Point kDefaultAppListAnchor(500, 750);

[msw, 2012/08/29 08:02:35]

nit: consider moving this static object to ShowAppList(); maybe the id too?

[xiyuan, 2012/08/29 17:39:15]

How is this anchor point picked? Just an arbitrary one for now? Should we use
percentage of screen instead?

Also, globals should only be POD types.

[benwells, 2012/08/30 06:51:30]

Done.

[benwells, 2012/08/30 06:51:30]

How is this picked: yes, this is just arbitrary for now. It will become (in a
follow up patch hopefully coming soon) something like near the cursor, with the
bubble arrow location changing to keep the view on screen and not conflicting
with the taskbar. I expect this to have some iterations as we get it feeling
correct.

Global non-POD: moved to ShowAppList.

+
+  class AppListControllerWin : public AppListController {
+   public:
+    AppListControllerWin() {}

[msw, 2012/08/29 08:02:35]

nit: the style guide discourages inline ctors and virtuals (many below).

[benwells, 2012/08/30 06:51:30]

Done.

+    virtual ~AppListControllerWin() {}
+
+   private:
+    // AppListController overrides:
+    virtual void CloseView() {}

[xiyuan, 2012/08/29 17:39:15]

How do we plan to implement this?

[benwells, 2012/08/30 06:51:30]

On Windows, when you hit ESC to close the app list, it closes. I haven't needed
to anything in particular. The delegate gets freed properly, and with the keep
alive stuff added the process is terminated if the launcher is the only thing
visible.

This is why I had initially (in an earlier CL) had this function called
something else (like ViewClosed) as I hadn't realised on Cros the controller has
to explicitly close the window.

Later, when / if we add fancy fade in / out animations on Windows I expect this
will change somewhat.

+
+    virtual bool IsAppPinned(const std::string& extension_id)  {
+      return false;
+    }
+
+    virtual void PinApp(const std::string& extension_id) OVERRIDE {}
+
+    virtual void UnpinApp(const std::string& extension_id) OVERRIDE {}
+
+    virtual bool CanPin() OVERRIDE {
+      return false;
+     }

[xiyuan, 2012/08/29 17:39:15]

nit: wrong indent

[benwells, 2012/08/30 06:51:30]

Done.

+
+    virtual void ActivateApp(Profile* profile,
+                             const std::string& extension_id,
+                             int event_flags) OVERRIDE {
+      ExtensionService* service = profile->GetExtensionService();
+      DCHECK(service);
+      const extensions::Extension* extension = service->GetInstalledExtension(
+          extension_id);
+      DCHECK(extension);
+      application_launch::OpenApplication(application_launch::LaunchParams(
+          profile, extension, extension_misc::LAUNCH_TAB, NEW_FOREGROUND_TAB));
+    }
+
+    virtual gfx::ImageSkia GetWindowAppIcon() OVERRIDE {
+      gfx::ImageSkia* resource = ResourceBundle::GetSharedInstance().
+          GetImageSkiaNamed(IDR_APP_LIST);
+      DCHECK(resource);
+      return *resource;
+    };
+
+    DISALLOW_COPY_AND_ASSIGN(AppListControllerWin);
+  };
+
+  // The AppListResources class manages global resources needed for the app
+  // list to operate.
+  class AppListResources {
+   public:
+    AppListResources::AppListResources() {
+      app_list::IconCache::CreateInstance();
+    }
+
+    app_list::PaginationModel* pagination_model() { return &pagination_model_; }
+
+   private:
+    app_list::PaginationModel pagination_model_;
+  };

[msw, 2012/08/29 08:02:35]

nit: DISALLOW_COPY_AND_ASSIGN.

[benwells, 2012/08/30 06:51:30]

Done.

+
+  base::LazyInstance<AppListResources>::Leaky
+    g_app_list_resources = LAZY_INSTANCE_INITIALIZER;
+}  // namespace
+
+namespace app_list_controller {
+  void ShowAppList() {
+    // The controller will be owned by the view delegate, and the delegate is
+    // owned by the app list view. The app list view manages it's own lifetime.
+    AppListControllerWin* controller = new AppListControllerWin();

[msw, 2012/08/29 08:02:35]

nit: consider nixing |controller|, passing new AppListControllerWin() directly.

[benwells, 2012/08/30 06:51:30]

Done.

+    app_list::AppListView* view = new app_list::AppListView(
+      new AppListViewDelegate(controller));

[msw, 2012/08/29 08:02:35]

nit: indent two more spaces.

[benwells, 2012/08/30 06:51:30]

Done.

+    view->InitAsBubble(
+        GetDesktopWindow(),
+        g_app_list_resources.Get().pagination_model(),
+        NULL,
+        kDefaultAppListAnchor,
+        views::BubbleBorder::BOTTOM_LEFT);
+    view->Show();
+    view->GetWidget()->GetTopLevelWidget()->UpdateWindowIcon();
+    ui::win::SetAppIdForWindow(kAppListAppId,
+        view->GetWidget()->GetTopLevelWidget()->GetNativeWindow());
+  }
+}  // namespace app_list_controller