Introduce App Launcher for Windows.

ui/app_list/app_list_view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/app_list/app_list_view.h"
 
 #include "base/string_util.h"
 #include "ui/app_list/app_list_bubble_border.h"
 #include "ui/app_list/app_list_item_view.h"
 #include "ui/app_list/app_list_model.h"
@@ skipping 33 matching lines @@
 
 AppListView::~AppListView() {
   // Deletes all child views while the models are still valid.
   RemoveAllChildViews(true);
 }
 
 void AppListView::InitAsBubble(
     gfx::NativeView parent,
     PaginationModel* pagination_model,
     views::View* anchor,
+    const gfx::Point& anchor_point,
     views::BubbleBorder::ArrowLocation arrow_location) {
+// TODO(benwells): Make the background painting consistent across ports.
+// This will require not doing it in the bubble border but in the view.

[xiyuan, 2012/08/29 17:39:15]

The reason to do it in bubble border is that it knows the right border path and
could properly clip the background color. It essentially does what
BubbleBackground does to paint the background until the next pixel to the
border.

I understand that we need to paint background for the view on Windows as the
contents is hosted in a different widget than the border on Windows. But even
with that, we still need to paint background somehow via BubbleFrameView (i.e.
using BubbleBorder or BubbleBackground). Otherwise, we might leave padding
pixels between the view and bubble border unpainted.

[benwells, 2012/08/30 06:51:30]

OK, for now I've removed this TODO and added one into the bubble border to
somehow draw the search box, separator etc.  on Windows. I'm not sure how to do
that yet with the least #iffery.

+#if defined(OS_WIN)
+  set_background(views::Background::CreateSolidBackground(
+      AppListBubbleBorder::ContentsBackgroundColor()));
+#else
   set_background(NULL);
+#endif
 
   SetLayoutManager(new views::BoxLayout(views::BoxLayout::kVertical,
                                         kInnerPadding,
                                         kInnerPadding,
                                         kInnerPadding));
 
   search_box_view_ = new SearchBoxView(this);
   AddChildView(search_box_view_);
 
   contents_view_ = new ContentsView(this, pagination_model);
   AddChildView(contents_view_);
 
   search_box_view_->set_contents_view(contents_view_);
 
   set_anchor_view(anchor);
+  set_anchor_point(anchor_point);

[xiyuan, 2012/08/29 17:39:15]

on Windows, think you also need
set_color(AppListBubbleBorder::ContentsBackgroundColor()) here. This sets the
background color for BubbleFrameView to paint the right background.

[benwells, 2012/08/30 06:51:30]

Maybe I'm missing some subtle detail but it looks OK as it is. Would this be
instead of the set_background call above?

[xiyuan, 2012/08/30 16:50:51]

We still need set_background call above because BubbleDelegateView
set_background with default white and we have to correct that.
set_color here would allow BubbleFrameView to create its BubbleBackground with
correct color so that the padding pixels (aka margin) between bubble contents
and border are drawn correctly.

The current color #fcfcfc might be very close to white and hard to tell the
difference. I have committed a CL to change the background color to #f5f5f5 and
that might make it more visible.

   set_margins(gfx::Insets());
   set_move_with_anchor(true);
   set_parent_window(parent);
   set_close_on_deactivate(false);
   set_anchor_insets(gfx::Insets(kArrowOffset, kArrowOffset, kArrowOffset,
       kArrowOffset));
   views::BubbleDelegateView::CreateBubble(this);
 
   // Overrides border with AppListBubbleBorder.
   bubble_border_ = new AppListBubbleBorder(this, search_box_view_);
   GetBubbleFrameView()->SetBubbleBorder(bubble_border_);
   SetBubbleArrowLocation(arrow_location);
 
+#if !defined(OS_WIN)
   // Resets default background since AppListBubbleBorder paints background.
   GetBubbleFrameView()->set_background(NULL);
+#endif
 
   CreateModel();
 }
 
 void AppListView::SetBubbleArrowLocation(
     views::BubbleBorder::ArrowLocation arrow_location) {
   DCHECK(bubble_border_);
   bubble_border_->set_arrow_location(arrow_location);
   SizeToContents();  // Recalcuates with new border.
 }
@@ skipping 28 matching lines @@
 
 bool AppListView::HasHitTestMask() const {
   return true;
 }
 
 void AppListView::GetHitTestMask(gfx::Path* mask) const {
   DCHECK(mask);
   bubble_border_->GetMask(GetBubbleFrameView()->bounds(), mask);
 }
 
+gfx::ImageSkia AppListView::GetWindowAppIcon() {
+  if (delegate_.get())
+    return delegate_->GetWindowAppIcon();
+
+  return gfx::ImageSkia();
+}
+
 bool AppListView::OnKeyPressed(const ui::KeyEvent& event) {
   if (event.key_code() == ui::VKEY_ESCAPE) {
     Close();
     return true;
   }
 
   return false;
 }
 
 void AppListView::ButtonPressed(views::Button* sender, const ui::Event& event) {
@@ skipping 50 matching lines @@
 }
 
 void AppListView::InvokeResultAction(const SearchResult& result,
                                      int action_index,
                                      int event_flags) {
   if (delegate_.get())
     delegate_->InvokeSearchResultAction(result, action_index, event_flags);
 }
 
 }  // namespace app_list