chrome/test/functional/downloads.py - Issue 10900010: Remove DownloadFileManager in favor of direct ownership of DownloadFiles.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/functional/downloads.py

Issue 10900010: Remove DownloadFileManager in favor of direct ownership of DownloadFiles. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixed race conditions and fixed a bug in downloads.py. Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/download/save_page_browsertest.cc ('K') | « chrome/browser/download/save_page_browsertest.cc ('k') | content/browser/browser_context.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/functional/downloads.py

diff --git a/chrome/test/functional/downloads.py b/chrome/test/functional/downloads.py

index 5efd799c5d91f177bafd67bc886bb1c90ea9f84c..432e5f5db1e37839e4f6c8256858381bf7695728 100755

--- a/chrome/test/functional/downloads.py

+++ b/chrome/test/functional/downloads.py

@@ -369,7 +369,7 @@ class DownloadsTest(pyauto.PyUITest):

resume_dict = self.PerformActionOnDownload(self._GetDownloadId(),

'toggle_pause')

self.assertFalse(resume_dict['is_paused'])

- self.WaitForAllDownloadsToComplete(timeout=self.large_test_timeout_ms());

+ self.WaitForAllDownloadsToComplete(timeout=10 * 60 * 1000);

# Verify that the file was correctly downloaded after pause and resume.

self.assertTrue(os.path.exists(downloaded_pkg),

« chrome/browser/download/save_page_browsertest.cc ('K') | « chrome/browser/download/save_page_browsertest.cc ('k') | content/browser/browser_context.cc » ('j') | no next file with comments »