Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3564)

Unified Diff: build/android/pylib/base_test_runner.py

Issue 10896050: Android: Use external storage for test data. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/android/pylib/base_test_runner.py
diff --git a/build/android/pylib/base_test_runner.py b/build/android/pylib/base_test_runner.py
index a21077effa0ba91db83a95e3f3ae3edacb8440b5..6b79231e62a18a3d9a2cf4bd99e9ff3e62ec916b 100644
--- a/build/android/pylib/base_test_runner.py
+++ b/build/android/pylib/base_test_runner.py
@@ -115,29 +115,6 @@ class BaseTestRunner(object):
os.path.join(constants.CHROME_DIR, p),
os.path.join(dest_dir, p))
- def LinkSdCardPathsToTempDir(self, paths):
- """Link |paths| which are under sdcard to constants.TEST_DATA_DIR.
-
- For example, the test data '/sdcard/my_data' will be linked to
- 'TEST_DATA_DIR/my_data'.
-
- Args:
- paths: A list of files and directories relative to /sdcard.
- """
- links = set()
- for path in paths:
- link_name = os.path.dirname(path)
- assert link_name, 'Linked paths must be in a subdir of /sdcard/.'
- link_name = link_name.split('/')[0]
- if link_name not in links:
- mapped_device_path = constants.TEST_DATA_DIR + '/' + link_name
- # Unlink the mapped_device_path at first in case it was mapped to
- # a wrong path. Add option '-r' becuase the old path could be a dir.
- self.adb.RunShellCommand('rm -r %s' % mapped_device_path)
- self.adb.RunShellCommand(
- 'ln -s /sdcard/%s %s' % (link_name, mapped_device_path))
- links.add(link_name)
-
def LaunchTestHttpServer(self, document_root, port=None,
extra_config_contents=None):
"""Launches an HTTP server to serve HTTP tests.

Powered by Google App Engine
This is Rietveld 408576698