src/trusted/debug_stub/win/platform_impl.cc - Issue 10896004: Don't modify memory access right when changing data in debug stub.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/trusted/debug_stub/win/platform_impl.cc

Issue 10896004: Don't modify memory access right when changing data in debug stub. (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client/

Patch Set: Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/trusted/debug_stub/win/platform_impl.cc

===================================================================

--- src/trusted/debug_stub/win/platform_impl.cc (revision 9590)

+++ src/trusted/debug_stub/win/platform_impl.cc (working copy)

@@ -11,6 +11,7 @@

#include <exception>

+#include "native_client/src/include/nacl_compiler_annotations.h"

#include "native_client/src/shared/platform/nacl_log.h"

#include "native_client/src/trusted/debug_stub/abi.h"

#include "native_client/src/trusted/debug_stub/platform.h"

@@ -47,7 +48,9 @@

return true;

}

-bool IPlatform::SetMemory(uint64_t virt, uint32_t len, void *src) {

+bool IPlatform::SetMemory(struct NaClApp* nap, uint64_t virt, uint32_t len,

Mark Seaborn 2012/08/30 16:55:57 Use the " *" spacing style here

halyavin 2012/08/31 08:01:24 Done.

+ void *src) {

+ UNREFERENCED_PARAMETER(nap);

uint32_t oldFlags = Reprotect(reinterpret_cast<void*>(virt),

len, PAGE_EXECUTE_READWRITE);

« src/trusted/debug_stub/posix/platform_impl.cc ('K') | « src/trusted/debug_stub/target.cc ('k') | tests/gdb/call.py » ('j') | tests/gdb/call.py » ('J')