remoting/protocol/host_event_dispatcher.cc - Issue 10894050: Remove support for Windows-style keycodes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/protocol/host_event_dispatcher.cc

Issue 10894050: Remove support for Windows-style keycodes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: DCHECK in EventExecutors if the USB keycode is missing Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: remoting/protocol/host_event_dispatcher.cc

diff --git a/remoting/protocol/host_event_dispatcher.cc b/remoting/protocol/host_event_dispatcher.cc

index 6ba6dd0f258f5c1e30f7fca0cbabfdc6855bb68d..f589e0d0a2c1bfba9c47513b795d59162d195bcb 100644

--- a/remoting/protocol/host_event_dispatcher.cc

+++ b/remoting/protocol/host_event_dispatcher.cc

@@ -38,8 +38,7 @@ void HostEventDispatcher::OnMessageReceived(

if (message->has_key_event()) {

const KeyEvent& event = message->key_event();

- if ((event.has_keycode() || event.has_usb_keycode()) &&

- event.has_pressed()) {

+ if (event.has_usb_keycode() && event.has_pressed()) {

input_stub_->InjectKeyEvent(event);

} else {

LOG(WARNING) << "Received invalid key event.";