Reworked previous CL (ExternalStringGetPeer speed up) to avoid the

runtime/vm/raw_object.h

Index: runtime/vm/raw_object.h
===================================================================
--- runtime/vm/raw_object.h	(revision 11534)
+++ runtime/vm/raw_object.h	(working copy)
@@ -1123,16 +1123,15 @@
 };
 
 
-DART_EXTERN_C {
-  Dart_Handle Dart_ExternalStringGetPeer(Dart_Handle, void**);
-}
-
-
 class RawExternalOneByteString : public RawString {
   RAW_HEAP_OBJECT_IMPLEMENTATION(ExternalOneByteString);
 
   ExternalStringData<uint8_t>* external_data_;
-  friend Dart_Handle Dart_ExternalStringGetPeer(Dart_Handle, void**);
+
+ public:
+  void* peer() {
+    return external_data_->peer();
+  }

[siva, 2012/08/29 19:39:11]

We generally try to restrict this file to just have data and avoid any functions
here.
RawObject is a special case as it is used by GC and Snapshot code.

[Tom Ball, 2012/08/29 20:03:50]

Ivan helped me rework the original code to avoid needing these, so they're gone
now.

On 2012/08/29 19:39:11, asiva wrote:

 };
 
 
@@ -1140,7 +1139,11 @@
   RAW_HEAP_OBJECT_IMPLEMENTATION(ExternalTwoByteString);
 
   ExternalStringData<uint16_t>* external_data_;
-  friend Dart_Handle Dart_ExternalStringGetPeer(Dart_Handle, void**);
+
+ public:
+  void* peer() {
+    return external_data_->peer();
+  }
 };
 
 
@@ -1148,7 +1151,11 @@
   RAW_HEAP_OBJECT_IMPLEMENTATION(ExternalFourByteString);
 
   ExternalStringData<uint32_t>* external_data_;
-  friend Dart_Handle Dart_ExternalStringGetPeer(Dart_Handle, void**);
+
+ public:
+  void* peer() {
+    return external_data_->peer();
+  }
 };