Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(864)

Issue 10890049: app_list: Touch scroll and animation improvement. (Closed)

Created:
8 years, 3 months ago by xiyuan
Modified:
8 years, 3 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

app_list: Touch scroll and animation improvement. - Use layer for AppListItemView for smoother animation and scroll transition; - Support reverse current animation in SelectPage so that we don't need to reset current animation on fling gesture; - Change fling speed threshold from 1100 to 800; - Lower finish transition threshold from 0.5 to 0.33; - Increase transition animation during from default 120ms to 180ms; - Use linear tween type for transition animation; Piggy backed with the change: - Change app menu background from #fcfcfc to #f5f5f5 BUG=145580 TEST=Manual, touch scroll and page transition animation should be smoother and more natural. App menu background is darker. R=sky@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=154106

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -53 lines) Patch
M ui/app_list/app_list_bubble_border.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/app_list/app_list_item_view.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/app_list/app_list_item_view.cc View 1 1 chunk +9 lines, -0 lines 0 comments Download
M ui/app_list/app_list_view.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/app_list/apps_grid_view.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/app_list/contents_view.cc View 3 chunks +9 lines, -4 lines 0 comments Download
M ui/app_list/pagination_model.h View 3 chunks +4 lines, -4 lines 0 comments Download
M ui/app_list/pagination_model.cc View 6 chunks +27 lines, -13 lines 0 comments Download
M ui/app_list/pagination_model_unittest.cc View 9 chunks +29 lines, -31 lines 0 comments Download
M ui/app_list/search_result_view.cc View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
xiyuan
8 years, 3 months ago (2012-08-29 23:18:21 UTC) #1
sky
LGTM
8 years, 3 months ago (2012-08-30 00:24:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xiyuan@chromium.org/10890049/2001
8 years, 3 months ago (2012-08-30 04:24:19 UTC) #3
commit-bot: I haz the power
Try job failure for 10890049-2001 (retry) on linux_rel for step "interactive_ui_tests". It's a second try, ...
8 years, 3 months ago (2012-08-30 05:53:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xiyuan@chromium.org/10890049/2001
8 years, 3 months ago (2012-08-30 07:24:43 UTC) #5
commit-bot: I haz the power
8 years, 3 months ago (2012-08-30 09:53:29 UTC) #6
Change committed as 154106

Powered by Google App Engine
This is Rietveld 408576698