Issue 1089004: Add binary operations with constants to the safe-int32 expression compiler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1089004: Add binary operations with constants to the safe-int32 expression compiler. (Closed)

Created:
10 years, 9 months ago by William Hesse

Modified:
9 years, 7 months ago

Reviewers:
fschneider

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Add binary operations with constants to the safe-int32 expression compiler. Committed: http://code.google.com/p/v8/source/detail?r=4230

Patch Set 1 #

Total comments: 2

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+64 lines, -17 lines)			Patch
	M	src/ia32/codegen-ia32.cc	View		2 chunks	+64 lines, -17 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

fschneider

LGTM. http://codereview.chromium.org/1089004/diff/1/2 File src/ia32/codegen-ia32.cc (right): http://codereview.chromium.org/1089004/diff/1/2#newcode7134 src/ia32/codegen-ia32.cc:7134: left.ToRegister(); Do we need right.ToRegister() here as well?

10 years, 9 months ago (2010-03-22 10:30:42 UTC) #2

William Hesse

10 years, 9 months ago (2010-03-23 10:19:45 UTC) #3

http://codereview.chromium.org/1089004/diff/1/2
File src/ia32/codegen-ia32.cc (right):

http://codereview.chromium.org/1089004/diff/1/2#newcode7134
src/ia32/codegen-ia32.cc:7134: left.ToRegister();
On 2010/03/22 10:30:42, fschneider wrote:
> Do we need right.ToRegister() here as well?

No.  If right is a constant we never get to this block.

Expand Messages | Collapse Messages