Install a user-level Start Menu shortcut for every user on system-installs through Active Setup

chrome/installer/setup/install_worker.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // This file contains the definitions of the installer functions that build
 // the WorkItemList used to install the application.
 
 #include "chrome/installer/setup/install_worker.h"
 
 #include <oaidl.h>
@@ skipping 890 matching lines @@
 
     AddUninstallShortcutWorkItems(installer_state, setup_path, new_version,
                                   install_list, *product);
 
     AddVersionKeyWorkItems(root, product->distribution(), new_version,
                            add_language_identifier, install_list);
 
     AddDelegateExecuteWorkItems(installer_state, src_path, new_version,
                                 *product, install_list);
 
-// TODO(gab): This is only disabled for M22 as the shortcut CL using Active
-// Setup will not make it in M22.
-#if 0
     AddActiveSetupWorkItems(installer_state, new_version, *product,
                             install_list);
-#endif
   }
 
   // Add any remaining work items that involve special settings for
   // each product.
   AddProductSpecificWorkItems(original_state, installer_state, setup_path,
                               new_version, install_list);
 
   // Copy over brand, usagestats, and other values.
   AddGoogleUpdateWorkItems(original_state, installer_state, install_list);
 
@@ skipping 325 matching lines @@
   }
 
   const HKEY root = HKEY_LOCAL_MACHINE;
   const string16 active_setup_path(GetActiveSetupPath(distribution));
 
   VLOG(1) << "Adding registration items for Active Setup.";
   list->AddCreateRegKeyWorkItem(root, active_setup_path);
   list->AddSetRegValueWorkItem(root, active_setup_path, L"",
                                distribution->GetAppShortCutName(), true);
 
   CommandLine cmd(installer_state.GetInstallerDirectory(new_version).

[grt (UTC plus 2), 2012/08/29 17:07:06]

i think you should add --system-level to the command-line so that setup.exe
knows it's running for a system-level install.  this impacts how things like the
InstallerState are initialized.  i also think you should use
product.AppendProductFlags so that --multi-install and --chrome are added if
it's a multi-install.

[gab, 2012/08/29 21:53:00]

Done already :).

       Append(installer::kSetupExe));
   cmd.AppendSwitch(installer::switches::kConfigureUserSettings);
   cmd.AppendSwitch(installer::switches::kVerboseLogging);
   list->AddSetRegValueWorkItem(root, active_setup_path, L"StubPath",
                                cmd.GetCommandLineString(), true);
 
   // TODO(grt): http://crbug.com/75152 Write a reference to a localized
   // resource.
   list->AddSetRegValueWorkItem(root, active_setup_path, L"Localized Name",
                                distribution->GetAppShortCutName(), true);
 
   list->AddSetRegValueWorkItem(root, active_setup_path, L"IsInstalled",
                                static_cast<DWORD>(1U), true);
 
-  string16 comma_separated_version(ASCIIToUTF16(new_version.GetString()));
-  ReplaceChars(comma_separated_version, L".", L",", &comma_separated_version);
+  // This is not the Chrome version. To have Active Setup run again for users
+  // that have already ran it, simply increase this number.

[grt (UTC plus 2), 2012/08/29 17:07:06]

ran -> run

[gab, 2012/08/29 21:53:00]

Done.

+  // Start at 23,0,0,0 because this was set to Chrome's version for a short
+  // period on dev-channel of Chrome 22.
+  static const wchar_t* kActiveSetupVersion = L"23,0,0,0";

[robertshield, 2012/08/29 16:59:30]

Please move this to the top of the file, also explain what Active Setup is in
the comment.

[gab, 2012/08/29 21:53:00]

Done.

   list->AddSetRegValueWorkItem(root, active_setup_path, L"Version",
-                               comma_separated_version, true);
+                               string16(kActiveSetupVersion), true);
 }
 
 namespace {
 
 enum ElevationPolicyId {
   CURRENT_ELEVATION_POLICY,
   OLD_ELEVATION_POLICY,
 };
 
 // Although the UUID of the ChromeFrame class is used for the "current" value,
@@ skipping 296 matching lines @@
                                  machine_state,
                                  setup_path,
                                  new_version,
                                  work_item_list,
                                  false,  // have_child_product
                                  cmd_line,
                                  kCmdQuickEnableApplicationHost);
 }
 
 }  // namespace installer